Modify

Opened 7 years ago

Closed 6 years ago

#8956 closed enhancement (fixed)

Produce warning if relations and members have same tags

Reported by: tumsi Owned by: tumsi
Priority: normal Milestone:
Component: Core validator Version: latest
Keywords: relation member same tag Cc: simon04

Description

Tags that cover all members of a relation shall be only stored at the relation and not additionally at its members (e.g., both show up "tag_z=value_c"). Sometimes there can be also observed inconsistent tags (e.g., "tag_x=value_a" at the relation and "tag_x=value_b"). In each case it would be great if JOSM shows up a warning.

Attachments (0)

Change History (6)

comment:1 Changed 7 years ago by skyper

Component: CoreCore validator
Keywords: relation member same tag added
Version: latest

comment:2 Changed 7 years ago by Don-vip

NodesDuplicatingWayTags test should be renamed and enhanced to support relations.

comment:4 Changed 6 years ago by Don-vip

Thanks to r6629 it's even easier :)

comment:5 Changed 6 years ago by Don-vip

Mmm not so easy in fact. I tried this, it works, but only if member and parent have the exact same collection of interesting tags, that's not what we want:

relation >:sameTags *:tagged {
  throwWarning: tr("Members duplicating parent relation tags");
}

comment:6 Changed 6 years ago by Don-vip

Cc: simon04 added
Owner: changed from team to tumsi
Status: newneedinfo

@tumsi: what concrete examples did you have in mind ?

I think we should only detect most common errors (building, landuse, natural).

Currently for multipolygons tagged both on the relation and the outer ways, it raises a "building inside building" or "overlapping xxx" warning, see also #9361

comment:7 Changed 6 years ago by stoecker

Resolution: fixed
Status: needinfoclosed

We totally discourage tags on outer ways now, so that ticket is no longer relevant.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain tumsi.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.