Modify

Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#8915 closed enhancement (fixed)

country specific turn arrows in Lane and Road attributes mappaint style

Reported by: yopaseopor Owned by: team
Priority: normal Milestone:
Component: External mappaint style Version:
Keywords: Lanes, road, attributes, preset Cc: imagic, bastiK

Description

I propose a "inside preset" for the style Lanes and Road attributes of Martin Vonwald.
But I have a little "problem", the arrows are not spanish.I can modify the arrows...but as a custom personal and manual thing.

I don't know anything about programming, so my question is simple.Is there any possibility that the style could include some "preset" changes between countries? So I can use your style but "with my arrows" with one-click o similar (like the roadsigns plugin for example)

Thanks for your attention
yopaseopor

Attachments (2)

arrows_spain_example.jpg (266.2 KB ) - added by yopaseopor 11 years ago.
Example of spanish arrows and also about differences about shapes.
es_arrows.zip (132.9 KB ) - added by yopaseopor 11 years ago.
Spanish set of road arrows

Download all attachments as: .zip

Change History (18)

comment:1 by Klumbumbus, 11 years ago

Which arrows do you mean? Can you please attach a screenshot? How do the spanish ones look like?

Last edited 11 years ago by Klumbumbus (previous) (diff)

by yopaseopor, 11 years ago

Attachment: arrows_spain_example.jpg added

Example of spanish arrows and also about differences about shapes.

comment:2 by yopaseopor, 11 years ago

Yes I can, Here it is an example of the differences of the shapes.Also I can afford you all the files of spanish and catalan arrows.

comment:3 by Klumbumbus, 11 years ago

Cc: imagic added

Maybe imagic can say somthing about, if he wants to include the spanish arrows into the style as alternative arrow style.

Otherwise maybe a copy of the whole style with the spanish arrows instead of the default arrows, named as "Lane and road attributes - spain version" in Styles would be a soluttion.

comment:4 by Don-vip, 11 years ago

I'd prefer to use a country/culture setting, like the stuff done for nodes in default map style :) ("Display street labels" and "Less obtrusive nodes...")

comment:5 by Don-vip, 11 years ago

Cc: bastiK added

Maybe this would require some work in core mappaint however?

in reply to:  5 comment:6 by Klumbumbus, 11 years ago

Replying to Don-vip:

Maybe this would require some work in core mappaint however?

Yeah, its a bit hard to choose between "default png", "default svg" and "spain" with one boolean :)

comment:7 by imagic, 11 years ago

Replying to yopaseopor:

But I have a little "problem", the arrows are not spanish.I can modify the arrows...but as a custom personal and manual thing.

About what arrows are you talking: png or svg?
I don't think, that we can provide different styles for svg arrows, but png should be possible. But please be aware that I intended to remove the png arrows in the future, because it is not possible to display all kind of different combinations. If someone needs the png I will keep the code for them, of course.

If you are talking about png: can you provide a complete set of images in the same format and size as the original arrows? Please take care of empty space around the actual arrows, transparency and correct alignment, otherwise the result will look odd.

Finally I want to add, that the arrows in the style are neither "austrian" nor "german" nor anything-else-kind-of-arrows: they are just arrows. So if it is not extremely important to you, maybe we should keep the style simple.

Replying to Klumbumbus:

Otherwise maybe a copy of the whole style with the spanish arrows instead of the default arrows, named as "Lane and road attributes - spain version" in Styles would be a soluttion.

Never a good idea. Then we have a spanish version and a catalan version and an italian and so on and after about five minutes all of them display something differently, behave differently and contain different errors. Keep it simple ;-)

Replying to Klumbumbus:

Yeah, its a bit hard to choose between "default png", "default svg" and "spain" with one boolean :)

There's nothing that another colour setting wouldn't solve ;-)


Finally: at the moment I'm a little "overemployed", so please dont expect this to be done tomorrow. (No, also not on monday).

in reply to:  7 comment:8 by Klumbumbus, 11 years ago

Replying to imagic:

I don't think, that we can provide different styles for svg arrows

Why?

Replying to Klumbumbus:

Yeah, its a bit hard to choose between "default png", "default svg" and "spain" with one boolean :)

There's nothing that another colour setting wouldn't solve ;-)

Of course, a color setting can do. I meant the "official" style settings in the mappaint style dialog, which Don-vip was talking about. They support only boolean atm.

comment:9 by yopaseopor, 11 years ago

Here it is all the "spanish/catalan arrows" ."Missing" arrows are because doesn't exists in Spain, so I put the "original" ones.In the zip I only include spanish arrows.

comment:10 by Klumbumbus, 11 years ago

Summary: Internal preset for change of country in Lane and Road attributes stylecountry specific turn arrows in Lane and Road attributes mappaint style

comment:11 by bastiK, 11 years ago

@yopaseopor: The more you prepare for the integration, the easier it gets for imagic to do the final steps.

TODO:

  • add a prefix the image files, so there is no clash with the original files
  • add a new color-option to activate the alternative png-style
  • make sure the correct set of images is selected, depending on the value of the new option

@imagic: There is now a build-in detection for right-hand traffic that can be used (see left-right-hand-traffic).

Last edited 11 years ago by bastiK (previous) (diff)

by yopaseopor, 11 years ago

Attachment: es_arrows.zip added

Spanish set of road arrows

comment:12 by yopaseopor, 11 years ago

prefix es_ added to the image files

comment:13 by imagic, 11 years ago

Resolution: fixed
Status: newclosed

Implemented in the latest version. The images for turn markings have been moved to images/png/turn-0/. Your images have been added to images/png/turn-1/. You may select which version to use with the setting integer.png.turn.variant. Don't forget to set boolean.use.svg.for.turning.marking to black; otherwise the embedded svg images are used.

comment:14 by yopaseopor, 11 years ago

One question: How I can access to select the version? How can I set boolean.use.svg.for.turning.marking ?
Thank you

in reply to:  14 comment:15 by Klumbumbus, 11 years ago

Replying to yopaseopor:

One question: How I can access to select the version? How can I set boolean.use.svg.for.turning.marking ?
Thank you

It is described here Styles/Lane_and_Road_Attributes

in reply to:  14 comment:16 by yopaseopor, 11 years ago

Replying to yopaseopor:

One question: How I can access to select the version? How can I set boolean.use.svg.for.turning.marking ?
Thank you

It works, thank you so very much :)

yopaseopor

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.