Modify

Opened 6 years ago

Closed 5 years ago

#8853 closed enhancement (fixed)

Search function needed

Reported by: skyper Owned by: team
Priority: normal Milestone:
Component: Plugin tagging-preset-tester Version:
Keywords: search Cc: stoecker

Description

It would be nice if a search function similar to the one in core would be added to the plugin. Especially when working on defaultpresets.xml the list of items gets quite long and if you do not know under which category the item is lying you can search a long time.

Thanks

Attachments (2)

smaller_left.png (92.5 KB) - added by skyper 5 years ago.
screenshot
bigger_right.png (106.6 KB) - added by skyper 5 years ago.
screenshot 2

Download all attachments as: .zip

Change History (19)

comment:1 Changed 6 years ago by akks

Cc: stoecker added

I have almost implemented it (reusing the F3 panel), but this needed a lot of refactoring in core (splitting 2000-lines TaggingPreset class into 5-6 smaller ones and extracting PresetSelector from F3 dialog)

@team: Are we still in the stabilization phase? ;)

comment:2 in reply to:  1 Changed 6 years ago by stoecker

Replying to akks:

@team: Are we still in the stabilization phase? ;)

If in the next two days after a release nothing dangerous pops up - No. You can reset the status yourself as well.

comment:3 Changed 6 years ago by akks

In 6068/josm:

see #8853: Massive (and dumb) refactoring of TaggingPreset class (splitting into smaller files)
Separate preset-choosing panel (TaggingPresetSelector class) for reuse not only in F3.

comment:4 Changed 6 years ago by AlfonZ

There seems to be one unusual character that javadoc doesn't like in [6068].

  [javadoc] ...\trunk\src\org\openstreetmap\josm\gui\tagging\TaggingPresetSelector.java:467: warning: unmappable character for encoding Cp1250
  [javadoc]     public void setClickListener(ActionListener ?lickListener) {
  [javadoc]                                                  ^
  [javadoc] ...\trunk\src\org\openstreetmap\josm\gui\tagging\TaggingPresetSelector.java:468: warning: unmappable character for encoding Cp1250
  [javadoc]         this.clickListener = ?lickListener;
  [javadoc]                               ^
  [javadoc] ...\trunk\src\org\openstreetmap\josm\gui\tagging\TaggingPresetSelector.java:467: illegal character: \65533
  [javadoc]     public void setClickListener(ActionListener ?lickListener) {
  [javadoc]                                                  ^
  [javadoc] ...\trunk\src\org\openstreetmap\josm\gui\tagging\TaggingPresetSelector.java:467: <identifier> expected
  [javadoc]     public void setClickListener(ActionListener ?lickListener) {
  [javadoc]                                                               ^
  [javadoc] ...\trunk\src\org\openstreetmap\josm\gui\tagging\TaggingPresetSelector.java:468: illegal character: \65533
  [javadoc]         this.clickListener = ?lickListener;
  [javadoc]                               ^
  [javadoc] ...\trunk\src\org\openstreetmap\josm\gui\tagging\TaggingPresetSelector.java:468: not a statement
  [javadoc]         this.clickListener = ?lickListener;
  [javadoc]                                ^

comment:5 Changed 6 years ago by stoecker

In 6069/josm:

see #8853 remove tabs, trailing spaces, windows line ends, strange characters

comment:6 Changed 6 years ago by stoecker

In 6070/josm:

see #8853 remove tabs, trailing spaces, windows line ends, strange characters

comment:7 Changed 6 years ago by akks

Oh, sorry. It was russian c and autocompletion. I am updating the plugin code now...

comment:8 Changed 6 years ago by akks

Commited it as [o29760] (new josm-latest required, of course).
Feel free to improve GUI or behavior.

comment:9 Changed 6 years ago by akks

For example, I do not know how to make it react on arrow keys (not only on clicks) without many false-positive events, like addListSelection does.

comment:10 Changed 6 years ago by skyper

@akks:
On wiki:/Plugins the description of this plugin says, that the .jar-file can be run on its own. I did never test that but will it still be possible after your changes ?

comment:11 in reply to:  10 Changed 6 years ago by AlfonZ

Cc: imi added

Replying to skyper:

@akks:
On wiki:/Plugins the description of this plugin says, that the .jar-file can be run on its own. I did never test that but will it still be possible after your changes ?

I tried to run it as standalone with java -cp tagging-preset-tester.jar;josm.jar org.openstreetmap.josm.plugins.taggingpresettester.TaggingPresetTester (is there a better way?) and it ran, but threw NullPointerException on loading preset xml. I guess it's not used in that way very much, as no one complained.

comment:12 Changed 6 years ago by akks

In 6072/josm:

see #8853: minor fixes in tagging preset selector (working without Main.main ,listening for selection)

comment:13 Changed 6 years ago by akks

Standalone mode an listening to selection was fixed in [o29762] (standalone was broken very long ago, now available on ant run)

comment:14 Changed 6 years ago by skyper

Thanks a lot so far !

One minor issue I noticed but did not mention so far (sorry):

There is a problem with the position of the divider when resizing the window. When resizing the window in width the left part suddenly gets wide, in favour of a smaller right part. Seems to happen at an certain width all the time.

Changed 5 years ago by skyper

Attachment: smaller_left.png added

screenshot

Changed 5 years ago by skyper

Attachment: bigger_right.png added

screenshot 2

comment:15 Changed 5 years ago by skyper

Replying to skyper:

Thanks a lot so far !

One minor issue I noticed but did not mention so far (sorry):

There is a problem with the position of the divider when resizing the window. When resizing the window in width the left part suddenly gets wide, in favour of a smaller right part. Seems to happen at an certain width all the time.

Tested again and still reproducable:

  1. open the plugin main window
  2. make it wider
  3. make it taller and look out for the jump to the right.

screenshot screenshot 2

comment:16 Changed 5 years ago by skyper

My issue is handled in #10331.

Replying to akks:

For example, I do not know how to make it react on arrow keys (not only on clicks) without many false-positive events, like addListSelection does.

There is also #9645 with a problem with selection.

comment:17 Changed 5 years ago by Don-vip

Cc: imi removed
Resolution: fixed
Status: newclosed

others issues are fixed.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.