Opened 10 years ago
Closed 9 years ago
#8853 closed enhancement (fixed)
Search function needed
Reported by: | skyper | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Plugin tagging-preset-tester | Version: | |
Keywords: | search | Cc: | stoecker |
Description
It would be nice if a search function similar to the one in core would be added to the plugin. Especially when working on defaultpresets.xml the list of items gets quite long and if you do not know under which category the item is lying you can search a long time.
Thanks
Attachments (2)
Change History (19)
comment:1 follow-up: 2 Changed 10 years ago by
Cc: | stoecker added |
---|
comment:2 Changed 10 years ago by
Replying to akks:
@team: Are we still in the stabilization phase? ;)
If in the next two days after a release nothing dangerous pops up - No. You can reset the status yourself as well.
comment:4 Changed 10 years ago by
There seems to be one unusual character that javadoc doesn't like in [6068].
[javadoc] ...\trunk\src\org\openstreetmap\josm\gui\tagging\TaggingPresetSelector.java:467: warning: unmappable character for encoding Cp1250 [javadoc] public void setClickListener(ActionListener ?lickListener) { [javadoc] ^ [javadoc] ...\trunk\src\org\openstreetmap\josm\gui\tagging\TaggingPresetSelector.java:468: warning: unmappable character for encoding Cp1250 [javadoc] this.clickListener = ?lickListener; [javadoc] ^ [javadoc] ...\trunk\src\org\openstreetmap\josm\gui\tagging\TaggingPresetSelector.java:467: illegal character: \65533 [javadoc] public void setClickListener(ActionListener ?lickListener) { [javadoc] ^ [javadoc] ...\trunk\src\org\openstreetmap\josm\gui\tagging\TaggingPresetSelector.java:467: <identifier> expected [javadoc] public void setClickListener(ActionListener ?lickListener) { [javadoc] ^ [javadoc] ...\trunk\src\org\openstreetmap\josm\gui\tagging\TaggingPresetSelector.java:468: illegal character: \65533 [javadoc] this.clickListener = ?lickListener; [javadoc] ^ [javadoc] ...\trunk\src\org\openstreetmap\josm\gui\tagging\TaggingPresetSelector.java:468: not a statement [javadoc] this.clickListener = ?lickListener; [javadoc] ^
comment:7 Changed 10 years ago by
Oh, sorry. It was russian c
and autocompletion. I am updating the plugin code now...
comment:8 Changed 10 years ago by
Commited it as [o29760] (new josm-latest required, of course).
Feel free to improve GUI or behavior.
comment:9 Changed 10 years ago by
For example, I do not know how to make it react on arrow keys (not only on clicks) without many false-positive events, like addListSelection does.
comment:10 follow-up: 11 Changed 10 years ago by
@akks:
On wiki:/Plugins the description of this plugin says, that the .jar-file can be run on its own. I did never test that but will it still be possible after your changes ?
comment:11 Changed 10 years ago by
Cc: | imi added |
---|
Replying to skyper:
@akks:
On wiki:/Plugins the description of this plugin says, that the .jar-file can be run on its own. I did never test that but will it still be possible after your changes ?
I tried to run it as standalone with java -cp tagging-preset-tester.jar;josm.jar org.openstreetmap.josm.plugins.taggingpresettester.TaggingPresetTester
(is there a better way?) and it ran, but threw NullPointerException on loading preset xml. I guess it's not used in that way very much, as no one complained.
comment:13 Changed 10 years ago by
Standalone mode an listening to selection was fixed in [o29762] (standalone was broken very long ago, now available on ant run
)
comment:14 Changed 10 years ago by
Thanks a lot so far !
One minor issue I noticed but did not mention so far (sorry):
There is a problem with the position of the divider when resizing the window. When resizing the window in width the left part suddenly gets wide, in favour of a smaller right part. Seems to happen at an certain width all the time.
comment:15 Changed 9 years ago by
Replying to skyper:
Thanks a lot so far !
One minor issue I noticed but did not mention so far (sorry):
There is a problem with the position of the divider when resizing the window. When resizing the window in width the left part suddenly gets wide, in favour of a smaller right part. Seems to happen at an certain width all the time.
Tested again and still reproducable:
- open the plugin main window
- make it wider
- make it taller and look out for the jump to the right.
comment:16 Changed 9 years ago by
comment:17 Changed 9 years ago by
Cc: | imi removed |
---|---|
Resolution: | → fixed |
Status: | new → closed |
others issues are fixed.
I have almost implemented it (reusing the F3 panel), but this needed a lot of refactoring in core (splitting 2000-lines TaggingPreset class into 5-6 smaller ones and extracting PresetSelector from F3 dialog)
@team: Are we still in the stabilization phase? ;)