Modify

Opened 11 years ago

Closed 11 years ago

#8827 closed defect (fixed)

HTML rendering differ if run before or after having launched Help Browser

Reported by: brycenesbitt Owned by: team
Priority: minor Milestone:
Component: Core Version:
Keywords: Cc:

Description

1> Bring up the new Download Location error dialog, it should look OK. Do this as many times as you like.
2> Now hit "help"
3) Now then bring up the same dialog, it will be missing spacing.


Attachments (3)

Download Location_07.png (37.4 KB ) - added by brycenesbitt 11 years ago.
Dialog showing bug triggered by HELP button.
findSummaryDocumentation_table.diff (1.1 KB ) - added by brycenesbitt 11 years ago.
Patch to add proper <table></table> to findSummaryDocumentation
Download Location_06.png (43.9 KB ) - added by brycenesbitt 11 years ago.
After patch applied (note table borders).

Download all attachments as: .zip

Change History (12)

by brycenesbitt, 11 years ago

Attachment: Download Location_07.png added

Dialog showing bug triggered by HELP button.

by brycenesbitt, 11 years ago

Patch to add proper <table></table> to findSummaryDocumentation

by brycenesbitt, 11 years ago

Attachment: Download Location_06.png added

After patch applied (note table borders).

comment:1 by brycenesbitt, 11 years ago

Here's what it looks like after hitting HELP:
Dialog showing bug triggered by HELP button.
Unfortunately the patch does not fully solve the problem, but it does help:
After patch applied (note table borders).

comment:2 by Don-vip, 11 years ago

Mmm I don't like this border, we need to find a better fix.

comment:3 by Don-vip, 11 years ago

Priority: normalminor

comment:4 by brycenesbitt, 11 years ago

There are two separate parts to the bug report:
1) The existing implementation has <tr> rows without an enclosing <table> (that's the patch).
2) Activating HELP for the first time causes the table tags to be ignored completely (that the observable bug).
The provision of <table border=1> or <table border=0> is an implementation choice once you have a table tag to work with. Another very compact solution is to use <td valign=top> on the task name cells.

Last edited 11 years ago by brycenesbitt (previous) (diff)

comment:5 by Don-vip, 11 years ago

Mmm I was pretty sure to have put <table> tag, and finally forgotten it :D

However adding it with your patch does not solve the issue, I am able to reproduce it with valid HTML 3.2, I don't see why.

comment:6 by brycenesbitt, 11 years ago

Very odd.
Is the HELP inserting some CSS into the mix to set formatting?
Does the internal HTML system even support CSS?

Last edited 11 years ago by brycenesbitt (previous) (diff)

comment:7 by Don-vip, 11 years ago

Found why. Yes we are using stylesheets in Help Browser.

The odd point is this method of Java:

http://docs.oracle.com/javase/6/docs/api/javax/swing/text/html/HTMLEditorKit.html#setStyleSheet(javax.swing.text.html.StyleSheet)

Set the set of styles to be used to render the various HTML elements. These styles are specified in terms of CSS specifications. Each document produced by the kit will have a copy of the sheet which it can add the document specific styles to. By default, the StyleSheet specified is shared by all HTMLEditorKit instances. This should be reimplemented to provide a finer granularity if desired.

Seriously ?? I wonder what Sun had in mind when they did this o_O

comment:8 by Don-vip, 11 years ago

Summary: [Patch] bug in #8809 - no tableHTML rendering differ if run before or after having launched Help Browser

comment:9 by Don-vip, 11 years ago

Resolution: fixed
Status: newclosed

In 6040/josm:

fix #8827 - HTML rendering differ if run before or after having launched Help Browser

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.