[Patch] to defaultpresets.xml : toilets/drinking water/farm stands

[brycenesbitt]

Do you accept patches to defaultpresets.xml? Here are a few tweaks to get people going in the right direction.

If it's OK, I'm happy to check this into the main osm svn... but is that a mirror of the josm svn?

[brycenesbitt]

Original image to go with the Farm Stand preset insert in images/presets

[stoecker]

This is an all-your-local changes patch :-) You should strip it to the relevant parts.

[brycenesbitt]

Diff of defaultpresets.xml . Note preset for Farm Stand is a preset only, not reflected in rendering.

[brycenesbitt]

Diff of defaultpresets.xml . Note preset for Farm Stand is a preset only, not reflected in rendering.

[skyper]

@brycenesbitt:

There are too many white spaces in your patch. Please stick to the common syntax with only one white space after the first entry of each line. Thanks

[brycenesbitt]

Revision 3: per request, don't line up key values.

[brycenesbitt]

As you wish. Spaces added to line up columns for human consumption have been removed.

[brycenesbitt]

You can see a grid of various editor preset support here: ​http://obviously.com/temp/osm/osmlg.html
Josm has the most presets :-)

[Don-vip]

This list is not 100% correct, I am pretty sure we support the denomination tags.

[AlfonZ]

My first impression was that is listed top-level tags only, thus denomination, being under amenity=place_of_worship, did not make it.
However, it also says JOSM has no traffic_calming=yes, so it seems more like some difficulty with parsing combos.

[skyper]

Replying to AlfonZ:

My first impression was that is listed top-level tags only, thus denomination, being under amenity=place_of_worship, did not make it.
However, it also says JOSM has no traffic_calming=yes, so it seems more like some difficulty with parsing combos.

+1

railway=rail
service=spur

is another example.

[brycenesbitt]

You're welcome to open a separate bug report for the comparison grid ;-).
The goal of the comparison grid is limited to the top level presets from (josm/data/defaultpresets.xml).
A second future chart will document all the combinations, with a goal of finding conflicts between recommended combinations among different editors.

However, this ticket is about refreshing certain presets (especially drinking water, of which I've helped add over a 1000 to OSM). Are tickets the proper procedure for requesting preset adjustments? Are those adjustments made rarely, or routinely, in JOSM?

[stoecker]

Last patch looks good for me on first view. Tickets are the right way to request anything in JOSM :-)

[skyper]

Replying to brycenesbitt:

You're welcome to open a separate bug report for the comparison grid ;-).
The goal of the comparison grid is limited to the top level presets from (josm/data/defaultpresets.xml).
A second future chart will document all the combinations, with a goal of finding conflicts between recommended combinations among different

Not sure if this really belongs to JOSM + jmapviewer (e.g. on this site). Probably a project for ​OSM-trac

[stoecker]

In 6044/josm:

fix #8815 - improve presets - patch by brycenesbitt

[rickmastfan67]

You forgot to add the "apple.png" file to JOSM that is at the top of this ticket. Saw this in the console when starting up the new "latest" file.

Failed to locate image 'presets/apple.png'
Could not get presets icon presets/apple.png

[Don-vip]

In 6045/josm:

fix #8815 - add missing icon