Modify

Opened 7 years ago

Closed 7 years ago

#8815 closed enhancement (fixed)

[Patch] to defaultpresets.xml : toilets/drinking water/farm stands

Reported by: brycenesbitt Owned by: team
Priority: minor Milestone:
Component: Internal preset Version:
Keywords: Cc:

Description

Do you accept patches to defaultpresets.xml? Here are a few tweaks to get people going in the right direction.

If it's OK, I'm happy to check this into the main osm svn... but is that a mirror of the josm svn?

Attachments (4)

apple.png (664 bytes) - added by brycenesbitt 7 years ago.
Original image to go with the Farm Stand preset insert in images/presets
presets.2.diff (4.3 KB) - added by brycenesbitt 7 years ago.
Diff of defaultpresets.xml . Note preset for Farm Stand is a preset only, not reflected in rendering.
presets.diff (4.3 KB) - added by brycenesbitt 7 years ago.
Diff of defaultpresets.xml . Note preset for Farm Stand is a preset only, not reflected in rendering.
presets.3.diff (4.3 KB) - added by brycenesbitt 7 years ago.
Revision 3: per request, don't line up key values.

Download all attachments as: .zip

Change History (18)

Changed 7 years ago by brycenesbitt

Attachment: apple.png added

Original image to go with the Farm Stand preset insert in images/presets

comment:1 Changed 7 years ago by stoecker

This is an all-your-local changes patch :-) You should strip it to the relevant parts.

Changed 7 years ago by brycenesbitt

Attachment: presets.2.diff added

Diff of defaultpresets.xml . Note preset for Farm Stand is a preset only, not reflected in rendering.

Changed 7 years ago by brycenesbitt

Attachment: presets.diff added

Diff of defaultpresets.xml . Note preset for Farm Stand is a preset only, not reflected in rendering.

comment:2 Changed 7 years ago by skyper

Summary: Patch to defaultpresets.xml : toilets/drinking water/farm stands[Patch] to defaultpresets.xml : toilets/drinking water/farm stands

comment:3 Changed 7 years ago by skyper

@brycenesbitt:

There are too many white spaces in your patch. Please stick to the common syntax with only one white space after the first entry of each line. Thanks

Changed 7 years ago by brycenesbitt

Attachment: presets.3.diff added

Revision 3: per request, don't line up key values.

comment:4 Changed 7 years ago by brycenesbitt

As you wish. Spaces added to line up columns for human consumption have been removed.

comment:5 Changed 7 years ago by brycenesbitt

You can see a grid of various editor preset support here: http://obviously.com/temp/osm/osmlg.html
Josm has the most presets :-)

Last edited 7 years ago by Don-vip (previous) (diff)

comment:6 Changed 7 years ago by Don-vip

This list is not 100% correct, I am pretty sure we support the denomination tags.

comment:7 Changed 7 years ago by AlfonZ

My first impression was that is listed top-level tags only, thus denomination, being under amenity=place_of_worship, did not make it.
However, it also says JOSM has no traffic_calming=yes, so it seems more like some difficulty with parsing combos.

comment:8 in reply to:  7 Changed 7 years ago by skyper

Replying to AlfonZ:

My first impression was that is listed top-level tags only, thus denomination, being under amenity=place_of_worship, did not make it.
However, it also says JOSM has no traffic_calming=yes, so it seems more like some difficulty with parsing combos.

+1

railway=rail
service=spur

is another example.

Last edited 7 years ago by skyper (previous) (diff)

comment:9 Changed 7 years ago by brycenesbitt

You're welcome to open a separate bug report for the comparison grid ;-).
The goal of the comparison grid is limited to the top level presets from (josm/data/defaultpresets.xml).
A second future chart will document all the combinations, with a goal of finding conflicts between recommended combinations among different editors.

However, this ticket is about refreshing certain presets (especially drinking water, of which I've helped add over a 1000 to OSM). Are tickets the proper procedure for requesting preset adjustments? Are those adjustments made rarely, or routinely, in JOSM?

Last edited 7 years ago by brycenesbitt (previous) (diff)

comment:10 Changed 7 years ago by stoecker

Last patch looks good for me on first view. Tickets are the right way to request anything in JOSM :-)

comment:11 in reply to:  9 Changed 7 years ago by skyper

Replying to brycenesbitt:

You're welcome to open a separate bug report for the comparison grid ;-).
The goal of the comparison grid is limited to the top level presets from (josm/data/defaultpresets.xml).
A second future chart will document all the combinations, with a goal of finding conflicts between recommended combinations among different

Not sure if this really belongs to JOSM + jmapviewer (e.g. on this site). Probably a project for OSM-trac

comment:12 Changed 7 years ago by stoecker

Resolution: fixed
Status: newclosed

In 6044/josm:

fix #8815 - improve presets - patch by brycenesbitt

comment:13 Changed 7 years ago by rickmastfan67

Resolution: fixed
Status: closedreopened

You forgot to add the "apple.png" file to JOSM that is at the top of this ticket. Saw this in the console when starting up the new "latest" file.

Failed to locate image 'presets/apple.png'
Could not get presets icon presets/apple.png

comment:14 Changed 7 years ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 6045/josm:

fix #8815 - add missing icon

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.