Opened 12 years ago
Closed 12 years ago
#8815 closed enhancement (fixed)
[Patch] to defaultpresets.xml : toilets/drinking water/farm stands
Reported by: | brycenesbitt | Owned by: | team |
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | Internal preset | Version: | |
Keywords: | Cc: |
Description
Do you accept patches to defaultpresets.xml? Here are a few tweaks to get people going in the right direction.
If it's OK, I'm happy to check this into the main osm svn... but is that a mirror of the josm svn?
Attachments (4)
Change History (18)
by , 12 years ago
comment:1 by , 12 years ago
This is an all-your-local changes patch :-) You should strip it to the relevant parts.
by , 12 years ago
Attachment: | presets.2.diff added |
---|
Diff of defaultpresets.xml . Note preset for Farm Stand is a preset only, not reflected in rendering.
by , 12 years ago
Attachment: | presets.diff added |
---|
Diff of defaultpresets.xml . Note preset for Farm Stand is a preset only, not reflected in rendering.
comment:2 by , 12 years ago
Summary: | Patch to defaultpresets.xml : toilets/drinking water/farm stands → [Patch] to defaultpresets.xml : toilets/drinking water/farm stands |
---|
comment:3 by , 12 years ago
@brycenesbitt:
There are too many white spaces in your patch. Please stick to the common syntax with only one white space after the first entry of each line. Thanks
by , 12 years ago
Attachment: | presets.3.diff added |
---|
Revision 3: per request, don't line up key values.
comment:4 by , 12 years ago
As you wish. Spaces added to line up columns for human consumption have been removed.
comment:5 by , 12 years ago
You can see a grid of various editor preset support here: http://obviously.com/temp/osm/osmlg.html
Josm has the most presets :-)
comment:6 by , 12 years ago
This list is not 100% correct, I am pretty sure we support the denomination
tags.
follow-up: 8 comment:7 by , 12 years ago
My first impression was that is listed top-level tags only, thus denomination
, being under amenity=place_of_worship
, did not make it.
However, it also says JOSM has no traffic_calming=yes
, so it seems more like some difficulty with parsing combos.
comment:8 by , 12 years ago
Replying to AlfonZ:
My first impression was that is listed top-level tags only, thus
denomination
, being underamenity=place_of_worship
, did not make it.
However, it also says JOSM has notraffic_calming=yes
, so it seems more like some difficulty with parsing combos.
+1
railway=rail service=spur
is another example.
follow-up: 11 comment:9 by , 12 years ago
You're welcome to open a separate bug report for the comparison grid ;-).
The goal of the comparison grid is limited to the top level presets from (josm/data/defaultpresets.xml).
A second future chart will document all the combinations, with a goal of finding conflicts between recommended combinations among different editors.
However, this ticket is about refreshing certain presets (especially drinking water, of which I've helped add over a 1000 to OSM). Are tickets the proper procedure for requesting preset adjustments? Are those adjustments made rarely, or routinely, in JOSM?
comment:10 by , 12 years ago
Last patch looks good for me on first view. Tickets are the right way to request anything in JOSM :-)
comment:11 by , 12 years ago
Replying to brycenesbitt:
You're welcome to open a separate bug report for the comparison grid ;-).
The goal of the comparison grid is limited to the top level presets from (josm/data/defaultpresets.xml).
A second future chart will document all the combinations, with a goal of finding conflicts between recommended combinations among different
Not sure if this really belongs to JOSM + jmapviewer (e.g. on this site). Probably a project for OSM-trac
comment:13 by , 12 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
You forgot to add the "apple.png" file to JOSM that is at the top of this ticket. Saw this in the console when starting up the new "latest" file.
Failed to locate image 'presets/apple.png' Could not get presets icon presets/apple.png
Original image to go with the Farm Stand preset insert in images/presets