Modify

Opened 6 years ago

Last modified 5 years ago

#8802 new defect

[PATCH] "Zoom to gap" in relation editor does not work anymore

Reported by: anonymous Owned by: team
Priority: normal Milestone:
Component: Core Version: tested
Keywords: Cc:

Description

I'm using v5990 from webstart.

The "Zoom to gap" function in the relation editor does not work anymore. If you do "select next gap", the next gap is selected, but you can't zoom to it anymore because when you do a right-click on the member list, it immediately selects the way under the mouse.

Previously, doing a right-click did not select the way under the mouse and you could use "Zoom to gap" to make JOSM zoom to the way for that gap.
JOSM should not select the way under the mouse when you right-click it.

I can't tell exactly when this bug was introduced, but I think it was working at the start of the year.

Attachments (1)

8802.diff (8.6 KB) - added by Don-vip 6 years ago.
patch that replaces "zoom to gap" by a proper and simpler selection and zoom button

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by Don-vip

Introduced in r5958.

comment:2 Changed 6 years ago by Don-vip

Owner: changed from team to Don-vip
Status: newassigned

This old behaviour is really not intuitive, I plan to write a better one, based on the fact a right click should select a table row like I did in r5958.

Changed 6 years ago by Don-vip

Attachment: 8802.diff added

patch that replaces "zoom to gap" by a proper and simpler selection and zoom button

comment:3 Changed 6 years ago by Don-vip

Owner: changed from Don-vip to team
Status: assignednew
Summary: "Zoom to gap" in relation editor does not work anymore[PATCH] "Zoom to gap" in relation editor does not work anymore

@team: what do you think ?

comment:4 in reply to:  3 Changed 6 years ago by skyper

Replying to Don-vip:

@team: what do you think ?

+1

The old behaviour was stange and did not convince me. I am happy if this will work cleaner in the future.

comment:5 Changed 6 years ago by skyper

Any news ?

comment:6 Changed 6 years ago by akks

Does user need to sort, select and "zoom to" manually to see the gap with the patch?

comment:7 Changed 5 years ago by mdk

I'm not sure, if this is the right place (maybe reopen #7168), but If I try to fix a large route relation with only a few gaps, I use "Select next Gap" on the first entry and - nothing visual happens. The selection list on the right is unchanged. But if you scroll down the "Member" list manually, you will find that the is really a selected member followed by a gap (or nothing is selected, if there is no gap).

If the selected gap is visible, the "Zoom to" or "Zoom to Gap" can easily used on the selected member.

My suggestions:

  1. On "Select next Gap" or "Select previous Gap", scroll the "Member" list, so that the selected member (and the gap) is visible. This way, the user get a feedback from the functions.
  2. Let the user know, if there is no gap (left) instead of doing nothing. For example show a "No gap found" dialogue, if "Select next/previous Gap" found nothing.
  3. Maybe change the "Select next/previous Gap" to "Zoom to next/previous Gap" and combine both operations. I think normally the user is not really interested in the gap in the Member list without seeing the situation in map.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to anonymous
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.