Modify

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#8799 closed enhancement (fixed)

visitor pattern

Reported by: martin Owned by: team
Priority: trivial Milestone:
Component: Core Version:
Keywords: visitor pattern Cc:

Description (last modified by Don-vip)

Please rename the method

org.openstreetmap.josm.data.osm.IPrimitive.visit(PrimitiveVisitor visitor);

to GoF conventional:

IPrimitive.accept(PrimitiveVisitor visitor);

or

IPrimitive.acceptVisitor(PrimitiveVisitor visitor);

Attachments (1)

8799.patch (1.0 KB) - added by Gnonthgol 6 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 6 years ago by Don-vip

Description: modified (diff)
Keywords: pattern added

comment:2 Changed 6 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 6009/josm:

fix #8799 - Follow conventional visitor design pattern by renaming visit(Visitor) to accept(Visitor)

comment:3 Changed 6 years ago by Don-vip

In 6010/josm:

fix #8799 - Follow conventional visitor design pattern by renaming visit(Visitor) to accept(Visitor) (missing files from previous commit)

Changed 6 years ago by Gnonthgol

Attachment: 8799.patch added

comment:4 Changed 6 years ago by Gnonthgol

Resolution: fixedinvalid

You missed a spot.

comment:5 Changed 6 years ago by Don-vip

Resolution: invalidfixed

Thanks. Fixed in [o29684].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.