Modify

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#8770 closed defect (fixed)

JOSM calls lsb-release for every single action

Reported by: anonymous Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: Cc:

Description

JOSM recently became virtually unusable. It hangs on any action, if opening a dialog or closing it. I tracked it down to frequent calls to lsb-release, which in turn calls apt-cache policy which takes a few seconds on my system with many sources.
This behavior is extremely annoying, and I can't see any reason at all, why lsb-release should be called for what I'm doing.

Attachments (0)

Change History (6)

comment:1 Changed 7 years ago by Don-vip

Priority: criticalnormal
Last edited 7 years ago by Don-vip (previous) (diff)

comment:2 Changed 7 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 5994/josm:

fix #8770 - Call lsb-release only once

comment:3 Changed 7 years ago by xeen

while the patch caches the lsb-results, why does every action call buildOSDescription in the first place?

Last edited 7 years ago by xeen (previous) (diff)

comment:4 Changed 7 years ago by Don-vip

The "every single action" part is over-reacted, as the initial priority.
Maybe related to wms requests.

comment:5 in reply to:  4 Changed 7 years ago by anonymous

Replying to Don-vip:

The "every single action" part is over-reacted, as the initial priority.
Maybe related to wms requests.

No. Just opening the "Add Property" dialog triggered it. Or closing it...

comment:6 Changed 7 years ago by Don-vip

Ok, it's triggered with this stacktrace:

	Version.getAgentString(boolean) line: 238	
	Version.getAgentString() line: 218	
	Preferences.updateSystemProperties() line: 1334	
	Preferences.save() line: 592	
	Preferences.put(String, String) line: 554	
	WindowGeometry.remember(String) line: 255

It's because system properties are updated each time we save preferences, we save preferences each time a preference is set, and a number of dialogs see their size/position stored in preferences. Caching the OS details request is fine, nothing to do more IMHO.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.