Modify

Opened 12 years ago

Closed 12 years ago

#8760 closed defect (fixed)

Removing duplicate node (and then auto dress other errors) on element vertex also remove related building

Reported by: mcheck Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. I have to clean some duplicate lonely node on building vertex (was a my previous import) the nodes are coincident to vertex
  2. i want to clen them using josm error check auto dress, Josm detect this errors and correct it
  3. Josm correct it ok, but it delete the related building node, i still view the building
  4. then it give me in validation tha there are nodes without tag to dress if i do it the building will be deleted

What is the expected result?
Delete duplicate node without tag not node bind to building object

What happens instead?
Josm delete the building nodes (but the building is still visible)
then i warn me on node without tags and if i dress it (using validation Josm auto dress),
it delete building object...

So i have to select single vertex and manually try to delete (guessing) the right node (not linked to building)

Please provide any additional information below. Attach a screenshot if
possible.

Last Changed Date: 2013-05-07 14:05:08 +0200 (Tue, 07 May 2013)
Repository Root: http://josm.openstreetmap.de/svn
Last Changed Rev: 5939
Last Changed Author: stoecker
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Build-Date: 2013-05-08 01:34:29
URL: http://josm.openstreetmap.de/svn/trunk
Revision: 5939

Identification: JOSM/1.5 (5939 it) Linux Ubuntu 12.04.2 LTS
Memory Usage: 278 MB / 878 MB (202 MB allocated, but free)
Java version: 1.8.0-ea, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Dataset consistency test: No problems found

Plugin: AddrInterpolation (29435)
Plugin: FastDraw
Plugin: FixAddresses (29519)
Plugin: HouseNumberTaggingTool (29487)
Plugin: ImportImagePlugin (29531)
Plugin: OpeningHoursEditor (29435)
Plugin: PicLayer
Plugin: RoadSigns (29435)
Plugin: SimplifyArea (29435)
Plugin: buildings_tools
Plugin: continuosDownload (28565)
Plugin: contourmerge (1003)
Plugin: dataimport (29435)
Plugin: download_along (29435)
Plugin: ext_tools (29435)
Plugin: geotools (29435)
Plugin: graphview (29525)
Plugin: importvec (29435)
Plugin: irsrectify (29210)
Plugin: jts (29613)
Plugin: lakewalker (29435)
Plugin: log4j (29435)
Plugin: mirrored_download (29505)
Plugin: multipoly-convert (29435)
Plugin: namemanager (29435)
Plugin: opendata (29505)
Plugin: openstreetbugs (29435)
Plugin: pbf (29435)
Plugin: pdfimport (29435)
Plugin: photo_geotagging (29435)
Plugin: plastic_laf (29435)
Plugin: print (29529)
Plugin: proj4j (29435)
Plugin: reltoolbox (29535)
Plugin: reverter (29561)
Plugin: scripting (30400)
Plugin: tag2link (29461)
Plugin: tageditor (29435)
Plugin: tagging-preset-tester (29435)
Plugin: terracer (29509)
Plugin: turnlanes (29435)
Plugin: turnrestrictions (29435)
Plugin: utilsplugin2 (29615)
Plugin: walkingpapers (29480)
Plugin: waypoint_search (29435)
Plugin: wikipedia (29523)
Plugin: wms-turbo-challenge2 (29435)


...<snip>...

Attachments (1)

edificio.osm (5.0 KB ) - added by mcheck 12 years ago.
Building sample to test

Download all attachments as: .zip

Change History (6)

by mcheck, 12 years ago

Attachment: edificio.osm added

Building sample to test

comment:1 by mcheck, 12 years ago

Summary: Removing duplicate node on element vertices also remove related buildingRemoving duplicate node on element vertex also remove related building

comment:2 by mcheck, 12 years ago

A workaround, still using josm validation check:

A) - fix errors
B) - do not auto correct to auto fix them
C) - redo the validation check, josm do not give more other warnings... and auto correct option

So seems there is need to do something into validation logic

  • seems we need to force a revalidation check to avoid auto deleting of already dressed objects

Thanks

comment:3 by mcheck, 12 years ago

Summary: Removing duplicate node on element vertex also remove related buildingRemoving duplicate node (and then auto dress other errors) on element vertex also remove related building

comment:4 by skyper, 12 years ago

Component: CoreCore validator

comment:5 by Don-vip, 12 years ago

Resolution: fixed
Status: newclosed

In 5989/josm:

fix #8760 - When merging nodes, keep the oldest used one, not just only the oldest one.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.