Highway preset missing in "properties panel" if it's a closed loop, but not tagged "area=yes"

[rickmastfan67]

Steps to reproduce:

1. Download the following way: ​way/11699138
2. Select the downloaded way.

What happens:
Notice that in the "properties panel" there is no highway preset at the top like when you select a non-loop highway way.

What should happen:
When selecting the "loop" way, the highway preset for type of highway you selected should show up like a normal way that doesn't loop back on itself.

This happens will all types of highways that have presets.

[Don-vip]

In 5976/josm:

fix #8724 - Add closedway as supported type of more highways

[skyper]

Replying to Don-vip:

In 5976/josm:

fix #8724 - Add closedway as supported type of more highways

Sorry, I do not understand your change. As #8663 states, closedway is included in way.

Seems to me that code in some other place does not follow this rule.

[Don-vip]

Mmmm, it did fix the problem however.

[skyper]

Replying to Don-vip:

This will not work. Please think about external presets !
Either we change the definition of type:way (#8663) or the code creating the property toogle dialog and this link.

Mmmm, it did fix the problem however.

Only for highways but not for barrier=guard_rail for example.

[skyper]

I just played around a bit and found another problem with closedway <-> relation.

• As an area can always be a multipolygon relation we need to always add both (closedway + relation).
• On the other hand, it might be better to distinguish between relations, as this problem is only true for multipolygons and all other relations would probably be errors.