Modify

Opened 7 years ago

Closed 19 months ago

#8724 closed defect (fixed)

Highway preset missing in "properties panel" if it's a closed loop, but not tagged "area=yes"

Reported by: rickmastfan67 Owned by: team
Priority: minor Milestone:
Component: Internal preset Version: latest
Keywords: preset property toogle dialog Cc:

Description (last modified by Don-vip)

Steps to reproduce:

  1. Download the following way: way/11699138
  2. Select the downloaded way.

What happens:
Notice that in the "properties panel" there is no highway preset at the top like when you select a non-loop highway way.

What should happen:
When selecting the "loop" way, the highway preset for type of highway you selected should show up like a normal way that doesn't loop back on itself.

This happens will all types of highways that have presets.

Attachments (0)

Change History (10)

comment:1 Changed 7 years ago by skyper

Component: Internal presetCore

comment:2 Changed 7 years ago by Don-vip

Component: CoreInternal preset

comment:3 Changed 7 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 5976/josm:

fix #8724 - Add closedway as supported type of more highways

comment:4 in reply to:  3 Changed 7 years ago by skyper

Replying to Don-vip:

In 5976/josm:

fix #8724 - Add closedway as supported type of more highways

Sorry, I do not understand your change. As #8663 states, closedway is included in way.

Seems to me that code in some other place does not follow this rule.

comment:5 Changed 7 years ago by Don-vip

Mmmm, it did fix the problem however.

comment:6 in reply to:  5 Changed 7 years ago by skyper

Resolution: fixed
Status: closedreopened

Replying to Don-vip:

This will not work. Please think about external presets !
Either we change the definition of type:way (#8663) or the code creating the property toogle dialog and this link.

Mmmm, it did fix the problem however.

Only for highways but not for barrier=guard_rail for example.

comment:7 Changed 6 years ago by skyper

Component: Internal presetCore
Keywords: preset property toogle dialog added

comment:8 Changed 5 years ago by skyper

I just played around a bit and found another problem with closedway <-> relation.

  • As an area can always be a multipolygon relation we need to always add both (closedway + relation).
  • On the other hand, it might be better to distinguish between relations, as this problem is only true for multipolygons and all other relations would probably be errors.

comment:9 Changed 19 months ago by Don-vip

Description: modified (diff)

comment:10 Changed 19 months ago by Don-vip

Component: CoreInternal preset
Resolution: fixed
Status: reopenedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.