Modify

Opened 7 years ago

Closed 7 years ago

Last modified 4 years ago

#8644 closed defect (fixed)

[Patch] Wrong preset for "Reitplatz"

Reported by: NopMap Owned by: team
Priority: normal Milestone:
Component: Internal preset Version: latest
Keywords: Cc: imagic

Description

The preset for "Reitplatz" uses the tags sport=equestrian, leisure=horse_riding.

It should be leisure=pitch, sport=equestrian. Just the same like all other sports.

http://wiki.openstreetmap.org/wiki/Pitch
http://wiki.openstreetmap.org/wiki/Reitplatz#St.C3.A4lle_und_Reitanlagen

Attachments (2)

defaultpresets.xml.horse_riding.patch (2.4 KB) - added by skyper 7 years ago.
patch
defaultpresets.xml.horse_riding2.patch (2.7 KB) - added by skyper 7 years ago.
real patch version 2

Download all attachments as: .zip

Change History (14)

comment:1 in reply to:  description Changed 7 years ago by skyper

Cc: imagic added

Replying to NopMap:

The preset for "Reitplatz" uses the tags sport=equestrian, leisure=horse_riding.

It should be leisure=pitch, sport=equestrian. Just the same like all other sports.

http://wiki.openstreetmap.org/wiki/Pitch
http://wiki.openstreetmap.org/wiki/Reitplatz#St.C3.A4lle_und_Reitanlagen

The whole situation is a bit unclear:

  • The wiki page for leisure=horse_riding redirects to a proposed features "Riding Stable" and was created last autumn by a certain user who added several horse-specific tags in this period.
  • On the German wiki page for horse features leisure=horse_riding is only used for nodes but for sport=horse_racing leisure=pitch is used and leisure=track is not even mentioned.

comment:2 Changed 7 years ago by skyper

At least the German translation of leisure=track/pitch do not really work.

Last edited 7 years ago by skyper (previous) (diff)

Changed 7 years ago by skyper

patch

comment:3 Changed 7 years ago by skyper

Summary: Wrong preset for "Reitplatz"[Patch] Wrong preset for "Reitplatz"

Please find a patch attached.

Think translation for value track needs different cases for highway=track and leisure=track. Do not know how to change this in Launchpad and I suffer lots of timeout errors.

comment:4 Changed 7 years ago by stoecker

You need to add a context to the preset to one of the two. Then they will get different in launchpad.

For timeouts, you can increase Bug-Heat for https://bugs.launchpad.net/bugs/736005.

comment:5 in reply to:  4 Changed 7 years ago by skyper

Replying to stoecker:

You need to add a context to the preset to one of the two. Then they will get different in launchpad.

Do not really understand. Do you mean I need to add "track" as context to one preset.

Just noticed that my patch is needing some context for leisure=horse_riding to mark the difference.

For timeouts, you can increase Bug-Heat for https://bugs.launchpad.net/bugs/736005.

Done.

comment:6 Changed 7 years ago by skyper

One problem is that leisure=track is named "Racetrack" in the preset. (line 4006,r5914)

comment:7 Changed 7 years ago by stoecker

There is a key values_context="context" for values, name_context for name entries, ... (see TaggingPresets).

E.g. add add values_context="riding" to the horse related presets.

comment:8 in reply to:  7 Changed 7 years ago by skyper

Replying to stoecker:

There is a key values_context="context" for values, name_context for name entries, ... (see TaggingPresets).

E.g. add add values_context="riding" to the horse related presets.

Thanks.

I fear we need some values_context for track.

comment:9 Changed 7 years ago by skyper

I did rework the patch. Please have a look at version two.

comment:10 Changed 7 years ago by stoecker

Hmm, that is no proper patch in unified diff format.

Changed 7 years ago by skyper

real patch version 2

comment:11 in reply to:  10 Changed 7 years ago by skyper

Replying to stoecker:

Hmm, that is no proper patch in unified diff format.

Sorry, I did replace it.

comment:12 Changed 7 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 5942/josm:

fix #8644 - Update of horse-related presets (patch by skyper)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.