Modify

Opened 7 years ago

Closed 7 years ago

#8415 closed defect (fixed)

[patch] add shortcut for "upload selection"

Reported by: Cobra Owned by: team
Priority: minor Milestone:
Component: Core Version: latest
Keywords: Cc:

Description

There is neither a pre-defined shortcut nor an option to add a custom one to File/Upload selection.

This patch adds ctrl-shift-alt-u as shortcut.
Other meaningful combinations are either occupied by josm, a plugin or at least some systems.

Idea/wish by malenki.

Attachments (2)

shortcut_uploadSelection-5704.patch (1.2 KB) - added by Cobra 7 years ago.
shortcut_uploadSelection_1-5704.patch (2.1 KB) - added by Cobra 7 years ago.
Updated the patch to properly re-assign ctrl-shift-alt-u

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by Cobra

comment:1 Changed 7 years ago by malenki

Thanks. :)

comment:2 Changed 7 years ago by stoecker

Like any other also this shortcut is already taken: DevelopersGuide/ShortcutsList.

comment:3 Changed 7 years ago by malenki

Obviously it wouldn't be the only duplicate.
And up to now it is not possible to add a shortcut to "upload selection" by hand.

comment:4 Changed 7 years ago by Don-vip

It's used by the applet. I'd prefer see it used as proposed in this patch.

comment:5 in reply to:  2 Changed 7 years ago by Cobra

Replying to stoecker:

Like any other also this shortcut is already taken: DevelopersGuide/ShortcutsList.

Damn. I looked at the shortcut list in the preferences, which didn't have this one.

Possibilities:

  • steal it from the applet (my preferred solution) - who even uses that shortcut?
  • find another somewhat meaningful shortcut - ctrl-alt-up is caught by some window mangers
  • don't assign a default shortcut, leave it to the user

Any opinions?

comment:6 Changed 7 years ago by stoecker

Obviously it wouldn't be the only duplicate.

It would be. There are no duplicates in core. That new plugins will cause conflicts is hardly to be prevented.

steal it from the applet (my preferred solution) - who even uses that shortcut?

Using the shortcut and assign the applet a "no-shortcut" default sounds good for me.

Changed 7 years ago by Cobra

Updated the patch to properly re-assign ctrl-shift-alt-u

comment:7 Changed 7 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 5711/josm:

fix #8415 - Replaced shortcut Ctrl-Alt-Shift-U. It now uploads current selection instead of uploading preferences in the applet (patch by Cobra)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.