icons for scuba_diving and park_ride

[walterschloegl@…]

There is an icon for sport=diving.
The same icon could be used for sport=scuba_diving.
diving and/or scuba_diving could be added to the sport menu.

There is an icon for parking=park_and_ride.
The same icon could be used for amenity=parking + park_ride=* (yes|train|bus|...) except park_ride=no.
Additionally to park_ride=yes/no please add the following values in dropdown list.
park_ride=bus/train/tram/metro/ferry/highway according to ​http://wiki.openstreetmap.org/wiki/Park_ride (highway is defacto)

[Don-vip]

Ticket #9192 has been marked as a duplicate of this ticket.

[Don-vip]

From #9192 for point 1:
we should:

• add sport=scuba_diving to internal preset
• render it with a better icon than we do now for sport=diving. I like this kind of icon: ​https://wiki.openstreetmap.org/wiki/File:Diving-Spot.jpg (but not this terribly compressed jpeg version)
• deprecate sport=diving. See ​https://wiki.openstreetmap.org/wiki/Tag:sport%3Ddiving

[skyper]

scuba diving icon. License PD from ​http://www.wpclipart.com

[skyper]

Replying to Don-vip:

From #9192 for point 1:

• render it with a better icon than we do now for sport=diving. I like this kind of icon: ​osmwiki:File:Diving-Spot.jpg (but not this terribly compressed jpeg version)

Here you go:
Found it at ​www.wpclipart.com published under PD.

[skyper]

Replying to skyper:

Replying to Don-vip:

From #9192 for point 1:

• render it with a better icon than we do now for sport=diving. I like this kind of icon: ​osmwiki:File:Diving-Spot.jpg (but not this terribly compressed jpeg version)

Here you go:
Found it at ​www.wpclipart.com published under PD.

If you prefer the version width boarder, it is also available at the site above.

[Klumbumbus]

icon see [o30732]

[Klumbumbus]

In 7630/josm:

see #8281 - deprecate sport=diving, add preset and mappaint style for sport=scuba_diving

[Klumbumbus]

I will check the second part (parking) of this ticket in the next days.

[Klumbumbus]

There is an icon for parking=park_and_ride.

According to wiki, I will deprecate this tag and remove the icon for this.

The same icon could be used for amenity=parking + park_ride=* (yes|train|bus|...) except park_ride=no.

I will add this.

Additionally to park_ride=yes/no please add the following values in dropdown list. park_ride=bus/train/tram/metro/ferry/highway according to ​http://wiki.openstreetmap.org/wiki/Park_ride (highway is defacto)

This is already done except for "highway". "highway" doesn't make sense in my eyes and is also used only 16 times.

[Klumbumbus]

@team: when I replace an icon at ​https://trac.openstreetmap.org/browser/subversion/applications/share/map-icons/classic.small and the name is not the same like before should I simply delete the old icon or are there other projects which use these icons and maybe not notice the change?

(The reason that the new name is not the same like the old name can either be that the file extension changed from png to svg or like in this case it changed from diving to scuba_diving.)

[stoecker]

There was another users of these icons in the past. Not sure about today anymore.

[Klumbumbus]

I asked TomH. He has also no idea if other projects use the icons. I checked the changeset comments in the osm svn which contain the word "icon". I couldn't find a changeset in the last 2 years, which is related to these icons but not related to josm. So I assume, that JOSM is the only project and I will delete the old icons when I replace them by new ones to avoid a lot of unused/doubled icons.

[Klumbumbus]

park_ride icon: [o30752]

[Klumbumbus]

In [7635]:

fixes #8281 - deprecate parking=park_and_ride in favor of amenity=parking park_ride=yes (updated validator and mappaint style)

[Don-vip]

Pro tip: You can edit your commit message afterwards if you mispelled the ticket number, then the comment is automatically added, like if it was right from the beginning :)

[Klumbumbus]

Oh nice, thanks.