wireframe: hidden segments in selection preview highlighting

[skyper]

1. I have two buildings sharing one wall (two nodes). (see attachment).
2. wire frame mode
3. no selection
4. move the mouse over one of it and the object is highlighted in red.

Only on the left (A) all four segments are highlighted but on the right (B) the overlapping one is missing.

Please, highlight all segments in preview.

(Strange, gnome-screenshooter does not capture wire frame)

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2012-12-18 02:32:00
Last Changed Author: akks
Revision: 5623
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2012-12-17 08:00:31 +0100 (Mon, 17 Dec 2012)
Last Changed Rev: 5623

Identification: JOSM/1.5 (5623 de)
Memory Usage: 96 MB / 643 MB (49 MB allocated, but free)
Java version: 1.6.0_24, Sun Microsystems Inc., OpenJDK 64-Bit Server VM
Operating system: Linux
Dataset consistency test: No problems found

Plugin: PicLayer (28807)
Plugin: terracer (29047)
Plugin: utilsplugin2 (28807)

[skyper]

example file

[Don-vip]

Funny, I have the opposite behaviour. B is completely highlighted, but not A.

[Don-vip]

In 5652/josm:

fix #8276 - Fix display of highlighted ways in wireframe mode

[skyper]

Replying to Don-vip:

In 5652/josm:

fix #8276 - Fix display of highlighted ways in wireframe mode

Thanks, all segments are visible now, but there is still a minor problem as ways without tag but part of a relation are not highlighted at all. Do not know if this is intended and/or if this did happen before.

Anyway if the way without tags and a tagged way are overlapping and you hover you mouse on it, nothing is highlighted. Clicking on it selects the untagged way.

[Don-vip]

Replying to skyper:

Thanks, all segments are visible now, but there is still a minor problem as ways without tag but part of a relation are not highlighted at all. Do not know if this is intended and/or if this did happen before.

Anyway if the way without tags and a tagged way are overlapping and you hover you mouse on it, nothing is highlighted. Clicking on it selects the untagged way.

I don't think this is expected.

[skyper]

Ticket #8317 has been marked as a duplicate of this ticket.

[skyper]

Reason for not highlighting is simple. There are no ways to highlight (see #8317).

[akks]

Lines 172 and 175 are really suspicious - maybe that is why untagged way are not drawn?
​http://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/WireframeMapRenderer.java?rev=5652#L172

[Don-vip]

In 5657/josm:

fix #8276 - untagged ways not rendered in wireframe mode

[Don-vip]

Replying to akks:

Lines 172 and 175 are really suspicious - maybe that is why untagged way are not drawn?

You're right, I forgot to remove this condition while refactoring the code :D Much better now :)

[skyper]

Replying to Don-vip:

Replying to akks:

Lines 172 and 175 are really suspicious - maybe that is why untagged way are not drawn?

You're right, I forgot to remove this condition while refactoring the code :D Much better now :)

thanks