Modify

Opened 7 years ago

Closed 6 years ago

#8234 closed enhancement (fixed)

Icon image twice in source

Reported by: skyper Owned by: team
Priority: trivial Milestone: 14.02
Component: Core Version: latest
Keywords: Cc:

Description

source:/trunk/images/dialogs/remove.png and source:/trunk/images/dialogs/delete.png

are similar.

Attachments (0)

Change History (10)

comment:1 Changed 7 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 5605/josm:

fix #8234 - Icon image twice in source

comment:2 Changed 7 years ago by skyper

Resolution: fixed
Status: closedreopened

Found another pair:

source:/trunk/images/misc/buttonshow.png and source:trunk/images/dialogs/layerlist/eye.png

comment:3 Changed 7 years ago by simon04

$  rmlint images/

# Duplicate(s):
   ls images/updateselection.png
   rm images/updatedata.png
   rm images/updatemodified.png
   ls images/createcircle.png
   rm images/aligncircle.png
   ls images/presets/aerialway.png
   rm images/presets/gondola.png
   ls images/dialogs/delete.png
   rm images/dialogs/remove.png
   ls images/downloadreferrers.png
   rm images/download.png
   ls images/icons/atm.png
   rm images/icons/bank.png
   ls images/icons/parking.png
   rm images/icons/parking_cycle.png
   ls images/dialogs/changeset/valid.png
   rm images/dialogs/conflict/mergecomplete.png

I'd better wait until the end ob stabilization to avoid missing icons in e.g. plugins or custom styles …

comment:4 Changed 7 years ago by stoecker

Also it is not so easy, as for action the icon name is the base for toolbar entry. So the name must be unique or a proper toolbar-name must be supplied.

comment:5 Changed 7 years ago by Gnonthgol

Resolution: fixed
Status: reopenedclosed

comment:6 Changed 7 years ago by skyper

I am not sure if the list was complete. Maybe these images differ in transparent space around them like comment:2.

comment:7 Changed 7 years ago by skyper

Resolution: fixed
Status: closedreopened

comment:8 Changed 6 years ago by Don-vip

Milestone: 14.02

comment:9 in reply to:  2 Changed 6 years ago by Don-vip

Replying to skyper:

Found another pair:

source:/trunk/images/misc/buttonshow.png and source:trunk/images/dialogs/layerlist/eye.png

I won't touch this pair as they do not have the same size, probably for a good reason. Other ones listed by Simon may be reworked without too much risk.

comment:10 Changed 6 years ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 6814/josm:

fix #8234 - remove duplicated/unused icons + javadoc

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.