sorting associatedStreet relation broken

[skyper]

It seems to me that r5516 does not work as

1. automatical sorting first sorts by object type and than housenumbers but it should do it the opposite way.
2. If you just select the closed ways at the bottom of the relation and try to sort them it does not sort at all.
3. If you select just one single member and press sort it sorts but it should not.

Gonna attach an example file.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2012-11-26 02:30:58
Last Changed Author: simon04
Revision: 5600
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2012-11-25 21:24:25 +0100 (Sun, 25 Nov 2012)
Last Changed Rev: 5600

Identification: JOSM/1.5 (5600 de)
Memory Usage: 466 MB / 643 MB (181 MB allocated, but free)
Java version: 1.6.0_24, Sun Microsystems Inc., OpenJDK 64-Bit Server VM
Operating system: Linux
Dataset consistency test: No problems found

Plugin: PicLayer (28807)
Plugin: terracer (28807)
Plugin: utilsplugin2 (28807)

[skyper]

sample

[skyper]

Did some more sorting and even with only closed way role=house selected and it does rearrange but not right. Maybe some issue you with alphabetical numbering ?

What happens if there is more than one member with the same house number ? I suggest to:

1. place closed ways and
2. nodes

Cheers

[simon04]

trunk/src/org/openstreetmap/josm/tools/AlphanumComparator.java​ might be of interest for resolving this issue …

[Don-vip]

The current algorithm does not take into account addresses set on ways but only on nodes. I have to rethink it to match your example.

[Don-vip]

In 5603/josm:

fix #8224 - Relation sorting: run custom sorters before default one in order to take into account all primitives based on their role before their type -> this allows to sort associatedStreet houses if the addr:housenumber is set on a closed way instead of a node

[skyper]

Replying to Don-vip:

In 5603/josm:

fix #8224 - Relation sorting: run custom sorters before default one in order to take into account all primitives based on their role before their type -> this allows to sort associatedStreet houses if the addr:housenumber is set on a closed way instead of a node

Thanks.

Totally forgot about relations (site,multipolygon,...) but it works.

Only minor issue I have that the order of the elements with role=street is sometimes changed without closing any gaps. E.g. the relation is changed without any benefit.