Modify

Opened 7 years ago

Closed 7 years ago

#8196 closed defect (fixed)

ICONS for <combo> <list_entry> </combo>

Reported by: kendzi Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: Cc:

Description

This change-set completely breaks support for icons:
http://josm.openstreetmap.de/changeset/5543/josm

It hard-code size of icon to 24. This make icons useless because the are to small.

Please remove default size or allow to disable it.

Attachments (7)

old.png (92.3 KB) - added by kendzi 7 years ago.
new.png (57.8 KB) - added by kendzi 7 years ago.
TaggingPreset.java.patch (2.0 KB) - added by kendzi 7 years ago.
fix for bug
defaultpresets.xml.patch (950 bytes) - added by kendzi 7 years ago.
description of tag
fix.png (102.2 KB) - added by kendzi 7 years ago.
defaultpresets.xml_v2.patch (1.7 KB) - added by kendzi 7 years ago.
tagging-preset.xsd.patch (454 bytes) - added by kendzi 7 years ago.

Download all attachments as: .zip

Change History (15)

Changed 7 years ago by kendzi

Attachment: old.png added

Changed 7 years ago by kendzi

Attachment: new.png added

comment:1 Changed 7 years ago by Don-vip

Component: External presetCore
Priority: criticalnormal

Changed 7 years ago by kendzi

Attachment: TaggingPreset.java.patch added

fix for bug

Changed 7 years ago by kendzi

Attachment: defaultpresets.xml.patch added

description of tag

Changed 7 years ago by kendzi

Attachment: fix.png added

comment:2 Changed 7 years ago by kendzi

I added in path new attribute image_size for list_entry:

<combo text="Test" key="test">
   <list_entry value="image1" icon="image1.png"  icon_size="64"/>
   <list_entry value="image2" icon="image2.png"  icon_size="16"/>
   <list_entry value="image3" icon="image2.png"  /> <!-- default size of image file -->
</combo>

Please include this patch. With out it icons are useless.

comment:3 Changed 7 years ago by bastiK

Resolution: fixed
Status: newclosed

In 5582/josm:

fixed #8196 - preset icon size (patch by kendzi)

comment:4 Changed 7 years ago by bastiK

Ok, this works better...

comment:5 Changed 7 years ago by stoecker

Resolution: fixed
Status: closedreopened

The patch misses the correction of the xsd file, a documentation in the header text and an update of the wiki page.

Changed 7 years ago by kendzi

Attachment: defaultpresets.xml_v2.patch added

Changed 7 years ago by kendzi

Attachment: tagging-preset.xsd.patch added

comment:6 Changed 7 years ago by kendzi

xsd patch is in file tagging-preset.xsd.patch​
doc patch is in file defaultpresets.xml_v2.patch​

Which wiki page?

comment:7 Changed 7 years ago by stoecker

TaggingPresets (which probably could have some additional rework also :-)

comment:8 Changed 7 years ago by stoecker

Resolution: fixed
Status: reopenedclosed

In 5585/josm:

fix #8196 - patch by kendzi

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.