Modify

Opened 7 years ago

Closed 7 years ago

#8165 closed defect (wontfix)

Could you not copy source code but include jar dependencies.

Reported by: cedric.olivier@… Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: Cc: dpaleino

Description

I am packaging JOSM for fedora, I've seen many other projects source code in JOSM svn repository,
like :
src/com/kitfox/svg/ could be included in lib/svgsalamnder.jar
src/com/google/gdata/ could be included in lib/gdata-core.jar
src/com/drew/ could be included in lib/metadata-extractor.jar
src/gnu/getopt/ could be included in lib/gnu-getopt.jar
src/oauth/signpost/ could be included in lib/signpost-core.jar

If bugs are fixed upstream, they will not be in JOSM.
And if you need to modify the sources of these projects, it would be more free to inform upstream projects of your changes.

Regards,

Attachments (0)

Change History (8)

comment:1 Changed 7 years ago by skyper

Cc: dpaleino added

Debian mantainer would be happy about that, too, I guess

comment:2 Changed 7 years ago by dpaleino

Yes, definitely.

That would simplify my packaging work, see http://anonscm.debian.org/gitweb/?p=pkg-osm/josm.git;a=blob;f=debian/rules (line 42 onwards).

...and this bug also made me aware of src/gnu/ and src/org/jdesktop/(which I had totally missed).

Thanks for CCing me!

comment:3 Changed 7 years ago by stoecker

We wont do this for the normal version, as this would increase size a lot. If you want to do so for packaging, feel free to do it.

comment:4 Changed 7 years ago by dpaleino

It would be nice if, at least, there was a place with a list of 3rd party embedded code copies; so that we (downstream packagers) don't become crazy in looking at diffs at each new version :)

Also a simple wiki page would suffice, IMHO.

Thanks for reading, and considering this bug!

comment:5 Changed 7 years ago by bastiK

see #7192

comment:6 Changed 7 years ago by bastiK

In 5545/josm:

see #8165 - document 3rd party libs in README

comment:7 in reply to:  description Changed 7 years ago by bastiK

Replying to cedric.olivier@…:

If bugs are fixed upstream, they will not be in JOSM.

If we find bugs in these libs, we will probably try to get them fixed upstream, but most of the dependencies are fairly stable. It is no problem to update, but currently there is not much reason, "it just works".

And if you need to modify the sources of these projects, it would be more free to inform upstream projects of your changes.

Has already been done for some, but for gnu getopt and svg salamander it is not possible I guess.

comment:8 Changed 7 years ago by bastiK

Resolution: wontfix
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.