Modify

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#7192 closed defect (fixed)

compile error

Reported by: bastiK Owned by: jttt
Priority: normal Milestone:
Component: Core Version:
Keywords: Cc:

Description

src/org/openstreetmap/josm/gui/MainApplication.java:29: package org.jdesktop.swinghelper.debug does not exist

Attachments (0)

Change History (10)

comment:1 Changed 7 years ago by bastiK

In [4721/josm]:

use builder pattern for ImageProvider (see #7192)

EDIT: commit is not related to this ticket

Last edited 7 years ago by bastiK (previous) (diff)

comment:2 Changed 7 years ago by jttt

Resolution: fixed
Status: newclosed

In [4722/josm]:

Fix #7192 compile error

comment:3 Changed 7 years ago by jttt

Local build is fixed, I'm not sure about remote build, does it still use it's own script?

comment:4 in reply to:  3 Changed 7 years ago by bastiK

Replying to jttt:

Local build is fixed,

I still get runtime error

I'm not sure about remote build, does it still use it's own script?

Yes. Is debug.jar supposed to get distributed as part of the release?

comment:5 Changed 7 years ago by bastiK

Can we just copy this class? It doesn't seem to have any dependencies.

comment:6 Changed 7 years ago by jttt

Well, I don't really like that every dependency is copied into source tree, it's already quite a mess with all those externals. On the other hand, build scripts obviously can't copy referenced classes into one big josm-custom.jar and this is only one class so I'll copy it.

comment:7 Changed 7 years ago by jttt

In [4728/josm]:

Fix #7192: compile error

comment:8 in reply to:  6 Changed 7 years ago by stoecker

Replying to jttt:

Well, I don't really like that every dependency is copied into source tree, it's already quite a mess with all those externals. On the other hand, build scripts obviously can't copy referenced classes into one big josm-custom.jar and this is only one class so I'll copy it.

They can do so. But they can't evaluate what is really needed, which is possible when code is in SVN and compiled. The release version should be as small as possible and thus drops everything which is not really required.

comment:9 Changed 7 years ago by jttt

ProGuard can also optimize jar file by removing unused class (and optionally also methods and do other optimizations) and it works on compiled classes. There is already ant task in build.xml - dist-optimized - that should create similar jar as is done on server for official builds.

comment:10 Changed 7 years ago by stoecker

Maybe we switch to ant in future. But currently I don't think it is necessary.

There is also one additional reason for using sources instead of jar files. I can see what a java file does, I can't do so for a jar file.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain jttt.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.