#8017 closed defect (fixed)
JOSM downloaded with "?lang=en-GB" does not include "en_GB" locale
| Reported by: | pinkduck | Owned by: | stoecker |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Trac | Version: | |
| Keywords: | i18n | Cc: | stoecker |
Description (last modified by )
Using en-GB_josm-tested.jar (r5482) on XP SP3. If I show the History of a way then the History List View and Version labels display dates using en-US format “m/d/yy h:nn [ap]”. What I expect to see is en-GB format “dd/mm/yy HH:nn”. The Help > About dialogue shows a formatted date as expected. My regional settings are for English, United Kingdom with short date format “ddd d MMM yyy” and long date format “dddd d MMMM yyyy”.
Attachments (0)
Change History (12)
comment:2 by , 12 years ago
I only have Default (Auto-Determine) (currently set) and English as the available options under preferences > Look and Feel > Language. Perhaps this means the en-GB download isn't actually en-GB? I used http://josm.openstreetmap.de/josm-tested.jar?lang=en-GB as download source.
follow-up: 4 comment:3 by , 12 years ago
I tried downloading with ?lang=en_GB and that made the English, United Kingdom localisation available.
I suggest that the server URL rewriting should support the hyphen-minus language/country separator as well as the underscore. This used to be the case until a month or so ago.
comment:4 by , 12 years ago
| Cc: | added |
|---|---|
| Component: | Core → Trac |
| Keywords: | i18n added; history localise date removed |
| Owner: | changed from to |
| Summary: | Localise way history dates → JOSM downloaded with "?lang=en-GB" does not include "en_GB" locale |
| Version: | tested |
the server URL rewriting should support the hyphen-minus language/country separator as well as the underscore. This used to be the case until a month or so ago.
@Dirk: could you have a look at this ?
comment:5 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
en-GB never worked and I also don't like to implement it, as everywhere I know the underscore is used.
follow-up: 7 comment:6 by , 12 years ago
Aside from ISO standards of course.
If no change will be made then at least update the Translation wiki page to indicate that it should be en_GB and not en-GB as users naturally expect.
comment:7 by , 12 years ago
Hello,
If no change will be made then at least update the Translation wiki page to indicate that it should be en_GB and not en-GB as users naturally expect.
I didn't find any place which is described wrong.
comment:8 by , 12 years ago
| Description: | modified (diff) |
|---|
Sorry, I recalled the page incorrectly. It is in fact the Download information at http://josm.openstreetmap.de/wiki/Download - search for ?lang=
comment:9 by , 12 years ago
Again I don't see anything wrong. Language codes with extension aren't mentioned there at all. Otherwise it's a wiki. You can improve it yourself.
follow-up: 11 comment:10 by , 12 years ago
What was wrong was no information about needing to use the Java-specific underscore separator for language and country code. What remains wrong is that ?lang=zz causes a download of the en_US build with zz in the filename. This led to my bug report since ?lang=en-GB caused en_US to download.
I have amended the wiki page with a note to explain that an underscore is required and a link to the Translations page where the in-use locale codes are.
A 404 status would be helpful for ?lang= querystring parameters without a corresponding file.
Confusion was added by the About JOSM… dialog Info tab showing the last change date in fixed "(ddd, d MMM yyyy)" format.
comment:11 by , 12 years ago
Replying to pinkduck:
What was wrong was no information about needing to use the Java-specific underscore separator for language and country code.
Why should that be Java specific? This is simply the way any software I know specifies language files. Have a look at gettext and any Unix system. See also http://en.wikipedia.org/wiki/Locale.
What remains wrong is that ?lang=zz causes a download of the en_US build with zz in the filename. This led to my bug report since ?lang=en-GB caused en_US to download.
You now get an error message for unsupported parameters.
comment:12 by , 12 years ago
Thank you for adding the error message support.
I recall underscore separator being used by Java when taught it and recalling then that it seemed weird. Look to http://tools.ietf.org/html/rfc4646 and there the ABNF uses hyphens. Look at the language choices in Firefox or Internet Explorer and they are hyphen separated too. While it’s fine for internal locale code use to remain consistent with the development framework when it comes to user interface such as manual querystring addition it seems strange not to support a simple variation that will likely be requested. Would supporting hyphen separators cause more confusion to JOSM programmers than an underscore will to the average end-user?
Still, the situation now is better than it was.
I hope someone localises the About dialog last change date to use the regional long date format. Its presence seems a little quirky given the ISO format date just before it, so perhaps just remove it altogether.
You've got "en-GB_josm-tested.jar", ok, but could you check that the language used in JOSM is correctly set to "English (United Kingdom)" in the preferences ? Looks like it is set to "English".