Modify

Opened 8 years ago

Closed 7 years ago

#7758 closed defect (fixed)

building inside building test

Reported by: anonymous Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: Cc:

Description

  • it took too many time, even if there's no buildings.
  • it checks only buildings with "building=yes" (i suppose it should checking everything what have tag "building", except "building=no")

Attachments (0)

Change History (4)

comment:1 Changed 8 years ago by mrwojo

Component: CoreCore validator

comment:2 Changed 8 years ago by mrwojo

  • The apparent duration of the "building in building" check is affected by #7759. That bug makes it looks slow even when it's actually quick.
  • Also need to consider normal uses of building=entrance.

comment:3 Changed 8 years ago by anonymous

...

private static boolean isBuilding(OsmPrimitive p) {
  String v = p.get("building");
  return v != null && !v.equals("no") && !v.equals("entrance");
}

comment:4 Changed 7 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 5293/josm:

fix #7758 - Do not restrict building validator tests to "building=yes", but take into account "no" and "entrance"

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.