Modify

Opened 7 years ago

Closed 7 years ago

#7745 closed defect (fixed)

[PATCH] TagCheck reports an identical warning multiple times after viewing validator preferences

Reported by: mrwojo Owned by: team
Priority: minor Milestone:
Component: Core validator Version:
Keywords: Cc:

Description

With r5210

Repro:

  1. Create a simple way tagged highway=service and barrier=wall.
  2. Validate. You should see a warning: "barrier used on a way - Suspicious tag/value combinations (1)".
  3. Open JOSM's Preferences dialog. Open the Validator settings page. Just press OK.
  4. Validate. The number of warnings has incremented: "barrier used on a way - Suspicious tag/value combinations (2)". The single problematic way is being reported twice with an identical warning.

TagCheck.initializeData() is called once on startup and when the user presses "OK" on the Validator Preferences dialog. checkerData (and a few other static lists) is appended to every time initializeData() is called, but it's never reset anywhere, so checks are added redundantly without bound.

Attachments (1)

initializeData.patch (894 bytes) - added by mrwojo 7 years ago.
initializeData: clear the static lists first

Download all attachments as: .zip

Change History (2)

Changed 7 years ago by mrwojo

Attachment: initializeData.patch added

initializeData: clear the static lists first

comment:1 Changed 7 years ago by simon04

Resolution: fixed
Status: newclosed

In 5270/josm:

fix #7745 - TagCheck reports an identical warning multiple times after viewing validator preferences (patch by mrwojo)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.