Modify

Opened 8 years ago

Closed 7 years ago

#7658 closed defect (fixed)

[Patch] Splash screen displays `logo.png` from working directory

Reported by: simon04 Owned by: team
Priority: minor Milestone:
Component: Core Version:
Keywords: Cc:

Description

To reproduce:

  1. Put any image logo.png in the working directory
  2. Launch JOSM
  3. Notice that the image from 1. is displayed instead of the JOSM's logo.

Attachments (1)

7658.patch (612 bytes) - added by simon04 8 years ago.

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by simon04

Attachment: 7658.patch added

comment:1 Changed 8 years ago by stoecker

Actually that is a feature, so it is possible to replace the in-file icons. Thought probably it has security drawbacks.

comment:2 in reply to:  1 ; Changed 8 years ago by bastiK

Replying to stoecker:

Actually that is a feature, so it is possible to replace the in-file icons. Thought probably it has security drawbacks.

I think we should disable this feature.

If someone wants to replace preset or map images, they can can configure icon paths in the preferences. Are there really users who want to replace the logo and other GUI icons? An Einstein-option should suffice in this case.

comment:3 in reply to:  2 Changed 7 years ago by skyper

Replying to bastiK:

Replying to stoecker:

Actually that is a feature, so it is possible to replace the in-file icons. Thought probably it has security drawbacks.

I think we should disable this feature.

If someone wants to replace preset or map images, they can can configure icon paths in the preferences. Are there really users who want to replace the logo and other GUI icons? An Einstein-option should suffice in this case.

There is the debian package openstreetmap-map-icons but I do not really know how it is used.

comment:5 Changed 7 years ago by stoecker

Resolution: fixed
Status: newclosed

In 5946/josm:

fix #7658 - don't load icons from user relative paths (require explicit path settings)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.