Opened 14 years ago
Closed 13 years ago
#7658 closed defect (fixed)
[Patch] Splash screen displays `logo.png` from working directory
| Reported by: | simon04 | Owned by: | team |
|---|---|---|---|
| Priority: | minor | Milestone: | |
| Component: | Core | Version: | |
| Keywords: | Cc: |
Description
To reproduce:
- Put any image
logo.pngin the working directory - Launch JOSM
- Notice that the image from 1. is displayed instead of the JOSM's logo.
Attachments (1)
Change History (6)
by , 14 years ago
| Attachment: | 7658.patch added |
|---|
follow-up: 2 comment:1 by , 14 years ago
follow-up: 3 comment:2 by , 13 years ago
Replying to stoecker:
Actually that is a feature, so it is possible to replace the in-file icons. Thought probably it has security drawbacks.
I think we should disable this feature.
If someone wants to replace preset or map images, they can can configure icon paths in the preferences. Are there really users who want to replace the logo and other GUI icons? An Einstein-option should suffice in this case.
comment:3 by , 13 years ago
Replying to bastiK:
Replying to stoecker:
Actually that is a feature, so it is possible to replace the in-file icons. Thought probably it has security drawbacks.
I think we should disable this feature.
If someone wants to replace preset or map images, they can can configure icon paths in the preferences. Are there really users who want to replace the logo and other GUI icons? An Einstein-option should suffice in this case.
There is the debian package openstreetmap-map-icons but I do not really know how it is used.
comment:4 by , 13 years ago
They patch the source code, to make it work:
http://anonscm.debian.org/gitweb/?p=pkg-osm/josm.git;a=blob;f=debian/patches/02-elemstyles.patch;h=b826168613a6876883ef370a6d63f653e689bcba;hb=HEAD
Actually that is a feature, so it is possible to replace the in-file icons. Thought probably it has security drawbacks.