Opened 14 years ago
Closed 14 years ago
#7588 closed defect (duplicate)
[Patch] Negative incline value displays wrong direction arrows
| Reported by: | anonymous | Owned by: | team |
|---|---|---|---|
| Priority: | minor | Milestone: | |
| Component: | Core | Version: | tested |
| Keywords: | incline | Cc: | bastiK, stoecker |
Description
As it should, incline=down displays (for an unselected way) arrows correctly in reverse direction to the way.
However, negative incline values like incline=-10° or incline=-10% display the inclination arrows in the same direction as positive values, while they should be reversed just like with incline=down.
Attachments (1)
Change History (7)
by , 14 years ago
| Attachment: | 7588.patch added |
|---|
follow-up: 2 comment:1 by , 14 years ago
| Cc: | added |
|---|---|
| Summary: | Negative incline value displays wrong direction arrows → [Patch] Negative incline value displays wrong direction arrows |
follow-ups: 3 4 comment:2 by , 14 years ago
Replying to simon04:
Fixed in the attached patch (allows to use regular expressions for
reversedDirectionKeysanddirectionKeys).
stoecker, bastiK: Shall we apply this patch in the stabilization phase?
Not sure if needed. Incline rendering is broken for years now, just add oneway=yes to your way with incline=-10% and have a look !
comment:3 by , 14 years ago
follow-up: 5 comment:4 by , 14 years ago
Replying to skyper:
Replying to simon04:
Fixed in the attached patch (allows to use regular expressions for
reversedDirectionKeysanddirectionKeys).
stoecker, bastiK: Shall we apply this patch in the stabilization phase?
Not sure if needed. Incline rendering is broken for years now, just add oneway=yes to your way with incline=-10% and have a look !
Yeah, would be better to fix the underlying rendering problem. But that's been there for 5 years, hasn't happened yet, and is a lot more effort than the small patch that has practical value.
I would rather add the small patch to the broken system to make it at least little less broken, than wait for a larger rewrite, unless there is active effort to atually fixing it.
comment:5 by , 14 years ago
Replying to anonymous:
Yeah, would be better to fix the underlying rendering problem. But that's been there for 5 years, hasn't happened yet, and is a lot more effort than the small patch that has practical value.
I would rather add the small patch to the broken system to make it at least little less broken, than wait for a larger rewrite, unless there is active effort to atually fixing it.
Ok I got it.
@ simon04:
Do not forget this one.
comment:6 by , 14 years ago
| Resolution: | → duplicate |
|---|---|
| Status: | new → closed |
Closed as duplicate of #5983.
Fixed in the attached patch (allows to use regular expressions for
reversedDirectionKeysanddirectionKeys).stoecker, bastiK: Shall we apply this patch in the stabilization phase?