View → Map Paint Styles gives ArrayOutOfBounds if MapStyles were changed/updated

[xeen]

STR:

1. remove or add map paint style in the preferences
2. try to (de)select first or second entry in the View → Map Paint Styles menu

Build-Date: 2012-03-19 13:09:15
Revision: 5106
Is-Local-Build: true

Identification: JOSM/1.5 (5106 SVN en)
Memory Usage: 213 MB / 1752 MB (123 MB allocated, but free)
Java version: 1.6.0_26, Sun Microsystems Inc., Java HotSpot(TM) 64-Bit Server VM
Operating system: Linux
Dataset consistency test: No problems found

Plugin: restart (27852)

java.lang.ArrayIndexOutOfBoundsException: -1
	at java.util.ArrayList.get(ArrayList.java:324)
	at java.util.Collections$UnmodifiableList.get(Collections.java:1154)
	at org.openstreetmap.josm.gui.mappaint.MapPaintStyles.toggleStyleActive(MapPaintStyles.java:318)
	at org.openstreetmap.josm.gui.mappaint.MapPaintMenu$MapPaintAction.toggleStyle(MapPaintMenu.java:42)
	at org.openstreetmap.josm.gui.mappaint.MapPaintMenu$MapPaintAction.actionPerformed(MapPaintMenu.java:48)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1995)
	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2318)
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387)
	at javax.swing.JToggleButton$ToggleButtonModel.setPressed(JToggleButton.java:291)
	at javax.swing.AbstractButton.doClick(AbstractButton.java:357)
	at org.openstreetmap.josm.gui.util.StayOpenCheckBoxMenuItem.doClick(StayOpenCheckBoxMenuItem.java:90)
	at javax.swing.plaf.basic.BasicMenuItemUI.doClick(BasicMenuItemUI.java:809)
	at javax.swing.plaf.basic.BasicMenuItemUI$Handler.menuDragMouseReleased(BasicMenuItemUI.java:913)
	at javax.swing.JMenuItem.fireMenuDragMouseReleased(JMenuItem.java:568)
	at javax.swing.JMenuItem.processMenuDragMouseEvent(JMenuItem.java:465)
	at javax.swing.JMenuItem.processMouseEvent(JMenuItem.java:411)
	at javax.swing.MenuSelectionManager.processMouseEvent(MenuSelectionManager.java:305)
	at javax.swing.plaf.basic.BasicPopupMenuUI$MouseGrabber.eventDispatched(BasicPopupMenuUI.java:807)
	at java.awt.Toolkit$SelectiveAWTEventListener.eventDispatched(Toolkit.java:2366)
	at java.awt.Toolkit$ToolkitEventMulticaster.eventDispatched(Toolkit.java:2258)
	at java.awt.Toolkit.notifyAWTEventListeners(Toolkit.java:2216)
	at java.awt.Component.dispatchEventImpl(Component.java:4549)
	at java.awt.Container.dispatchEventImpl(Container.java:2099)
	at java.awt.Component.dispatchEvent(Component.java:4481)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4577)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4238)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4168)
	at java.awt.Container.dispatchEventImpl(Container.java:2085)
	at java.awt.Window.dispatchEventImpl(Window.java:2478)
	at java.awt.Component.dispatchEvent(Component.java:4481)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:643)
	at java.awt.EventQueue.access$000(EventQueue.java:84)
	at java.awt.EventQueue$1.run(EventQueue.java:602)
	at java.awt.EventQueue$1.run(EventQueue.java:600)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:98)
	at java.awt.EventQueue$2.run(EventQueue.java:616)
	at java.awt.EventQueue$2.run(EventQueue.java:614)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:613)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

[simon04]

In 5141/josm:

fix #7527 - View → Map Paint Styles gives ArrayOutOfBounds if MapStyles were changed/updated