#7421 closed enhancement (fixed)
[patch] circle created from way heads always clockwise
Reported by: | malenki | Owned by: | team |
---|---|---|---|
Priority: | minor | Milestone: | 15.05 |
Component: | Core | Version: | |
Keywords: | create circle | Cc: |
Description
If one creates a circle from a way with two nodes or a way forming a triangle the created circle always goes counter-clockwise.
Since this tool is often used to created roundabouts (speaking for me :) ) and there is mostly right hand traffic in the world imo it would be the better choice to have the created circle go clockwise.
Attachments (1)
Change History (19)
comment:1 by , 13 years ago
comment:2 by , 12 years ago
If you create a triangle with an anti-clockwise, then the circle generated is clockwise.
follow-up: 4 comment:3 by , 11 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Now circles are always created clockwise. For me this issue is resolved.
comment:4 by , 11 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Replying to malenki:
Now circles are always created clockwise. For me this issue is resolved.
No, just use a way from south to north.
I do not like the change of direction when using a triangle but I can live with it.
follow-up: 6 comment:5 by , 11 years ago
As I said:
Now circles are always created clockwise. For me this issue is resolved.
No matter from which place to where the way goes, also from south to north.
using r5977 (yesterdays latest)
comment:6 by , 11 years ago
Replying to malenki:
As I said:
Now circles are always created clockwise. For me this issue is resolved.
No matter from which place to where the way goes, also from south to north.
using r5977 (yesterdays latest)
I totally misread your argument. Your are right that it now creates all circles clockwise but talking about right hand traffic the roundabout is a one way anti-clockwise circle.
The only other use with explicit direction I can think of would be water. Think it was dropped from natural=water
but islands and coastline might still need one.
comment:7 by , 11 years ago
Darn. Must have been a moron who opened this bug. -.- *cough*
Coastline still needs an explicit direction, water and islands don't (afaik) though JOSM validator still reports when land is on the wrong side.
comment:8 by , 11 years ago
Well I still think:
- check the driving direction (default right -> counter clockwise)
- create
natural=coastline
always counter-clockwise - create
highway=*
depending on 1. - create a circle keeping the direction (3 nodes)
- create a counter-clockwise circle (2 nodes)
In any way it would make much sense to change the behaviour from clockwise to counter-clockwise.
comment:9 by , 11 years ago
Type: | defect → enhancement |
---|
comment:10 by , 11 years ago
Summary: | circle created from way heads always counter-clockwise → circle created from way heads always clockwise |
---|
comment:11 by , 11 years ago
Keywords: | create circle added |
---|
follow-up: 14 comment:12 by , 11 years ago
When I have changed CreateCircleAction for #5922, I didn't pay attention to circle direction.
But :
- I think checking driving direction is too complex. It need a driving direction database, does JOSM have one ?
natural=coastline
: Does circle are really necessary to draw coastline ?
The easiest way can be more useful.
- 2 nodes -> always anticlockwise. (We have to make a choice, anticlockwise is a good one)
- 3 nodes -> same direction as the selected node. (What is more intuitive for the user)
See attach patch.
by , 11 years ago
Attachment: | bug7421.patch added |
---|
comment:13 by , 11 years ago
Summary: | circle created from way heads always clockwise → [patch] circle created from way heads always clockwise |
---|
comment:14 by , 10 years ago
Replying to Balaitous:
When I have changed CreateCircleAction for #5922, I didn't pay attention to circle direction.
But :
- I think checking driving direction is too complex. It need a driving direction database, does JOSM have one ?
You are right. Maybe an option to change the default directions is nice for left-side driving regions but I am not sure if it is needed.
natural=coastline
: Does circle are really necessary to draw coastline ?
It is a nice starting object for small roundish isles. I did start to use "improve way accuracy" more than drawing mode.
The easiest way can be more useful.
- 2 nodes -> always anticlockwise. (We have to make a choice, anticlockwise is a good one)
- 3 nodes -> same direction as the selected node. (What is more intuitive for the user)
+1
comment:15 by , 10 years ago
Concerning attachment:bug7421.patch, the existing function org.openstreetmap.josm.tools.Geometry#angleIsClockwise(Node, Node, Node)
should be used.
comment:16 by , 10 years ago
There is now a left- and right-hand traffic database, which could be used (see [7193]).
comment:18 by , 10 years ago
Milestone: | → 15.05 |
---|
Replying to malenki:
No, first of all it should keep the direction (triangle), then (at least for highways) it probably should check the coordinates to determine the driving direction to use it as direction.