Modify

Opened 8 years ago

Closed 4 years ago

#7289 closed defect (fixed)

Bing: There should be a repaint when attribution data is ready

Reported by: bastiK Owned by: team
Priority: normal Milestone: 15.09
Component: Core imagery Version:
Keywords: Bing Cc: wiktorn

Description

When you open download dialog and change to Bing, it will show red error tiles and "loading Bing attribution data..." indefinitely. This changes on first zoom or pan, but it should automatically do a repaint as soon as the attribution data is ready. (Similar for the main map.)

This problem is visible since [o27483].

Attachments (2)

Bing_problems_in_r4418.png (42.2 KB) - added by rickmastfan67 8 years ago.
bing.attribution.rar (1.8 KB) - added by rickmastfan67 8 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 8 years ago by bastiK

Instead of the red error tiles there should be images that indicate something is still loading.

comment:2 Changed 8 years ago by rickmastfan67

Yeah, something is messed up here. All I'm getting is "Error: null" instead of images. So, I look in the CL and noticed there are some error messages. I'll attach of picture of the CL after this post showing the errors on r4818. If I go back to r4806, Bing works normally for me. I honestly wish there was an easier way to copy and paste the data in Windows from the Java Console.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2012-01-19 02:33:08
Last Changed Author: bastiK
Revision: 4818
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2012-01-18 20:43:48 +0100 (Wed, 18 Jan 2012)
Last Changed Rev: 4818

Identification: JOSM/1.5 (4818 en)
Memory Usage: 157 MB / 2730 MB (73 MB allocated, but free)
Java version: 1.6.0_30, Sun Microsystems Inc., Java HotSpot(TM) 64-Bit Server VM
Operating system: Windows 7
Dataset consistency test: No problems found

Plugin: OpeningHoursEditor (27355)
Plugin: buildings_tools (27355)
Plugin: imageryadjust (27355)
Plugin: licensechange (27472)
Plugin: mapdust (27355)
Plugin: measurement (27289)
Plugin: openstreetbugs (27355)
Plugin: restart (27289)
Plugin: reverter (27393)
Plugin: turnrestrictions (27355)
Plugin: undelete (27395)
Plugin: utilsplugin2 (27426)
Last edited 8 years ago by rickmastfan67 (previous) (diff)

Changed 8 years ago by rickmastfan67

Attachment: Bing_problems_in_r4418.png added

comment:3 Changed 8 years ago by simon04

Strange … Works fine here … I had this problem while developing, but it should be fixed now.

For investigating, could you please attach the file .josm/cache/bing.attribution.xml.

Changed 8 years ago by rickmastfan67

Attachment: bing.attribution.rar added

comment:4 Changed 8 years ago by rickmastfan67

There you go.

Also, #7291 might be related to this.

Last edited 8 years ago by rickmastfan67 (previous) (diff)

comment:5 in reply to:  4 ; Changed 8 years ago by simon04

Replying to rickmastfan67:

There you go.

This is in fact related to #7284, not this ticket.
Thank you. I don't understand why this problem occurs: The file contains the BOM (0xef 0xbb 0xbf), which should be handled by UTFInputStreamReader. Does this problem occur on other systems as well?

Also, #7291 might be related to this.

I don't see any connection to that issue.

comment:6 in reply to:  5 ; Changed 8 years ago by simon04

Replying to simon04:

Replying to rickmastfan67:

There you go.

This is in fact related to #7284, not this ticket.
Thank you. I don't understand why this problem occurs: The file contains the BOM (0xef 0xbb 0xbf), which should be handled by UTFInputStreamReader. Does this problem occur on other systems as well?

I could track down the problem to some encoding issue under Windows. Should be fixed in [o27491].

comment:7 Changed 8 years ago by stoecker

Are you sure it is a good idea to add a "ex.printStackTrace();" in library code?

comment:8 Changed 8 years ago by simon04

In [4825/josm]:

see #7289 - remove JOSM specific stuff from jmapviewer

comment:9 in reply to:  7 Changed 8 years ago by simon04

Replying to stoecker:

Are you sure it is a good idea to add a "ex.printStackTrace();" in library code?

Removed.

comment:10 in reply to:  6 Changed 8 years ago by rickmastfan67

Replying to simon04:

Replying to simon04:

Replying to rickmastfan67:

There you go.

This is in fact related to #7284, not this ticket.
Thank you. I don't understand why this problem occurs: The file contains the BOM (0xef 0xbb 0xbf), which should be handled by UTFInputStreamReader. Does this problem occur on other systems as well?

I could track down the problem to some encoding issue under Windows. Should be fixed in [o27491].

It doesn't seem to be fully fixed. However, I'll continue in #7284 since you said the problem was related to that ticket.

comment:11 Changed 7 years ago by skyper

Owner: changed from Upliner to team

comment:12 Changed 4 years ago by simon04

Cc: wiktorn added
Milestone: 15.09
Resolution: fixed
Status: newclosed

Fixed in r8714.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.