Bing: There should be a repaint when attribution data is ready

[bastiK]

When you open download dialog and change to Bing, it will show red error tiles and "loading Bing attribution data..." indefinitely. This changes on first zoom or pan, but it should automatically do a repaint as soon as the attribution data is ready. (Similar for the main map.)

This problem is visible since [o27483].

[bastiK]

Instead of the red error tiles there should be images that indicate something is still loading.

[rickmastfan67]

Yeah, something is messed up here. All I'm getting is "Error: null" instead of images. So, I look in the CL and noticed there are some error messages. I'll attach of picture of the CL after this post showing the errors on r4818. If I go back to r4806, Bing works normally for me. I honestly wish there was an easier way to copy and paste the data in Windows from the Java Console.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2012-01-19 02:33:08
Last Changed Author: bastiK
Revision: 4818
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2012-01-18 20:43:48 +0100 (Wed, 18 Jan 2012)
Last Changed Rev: 4818

Identification: JOSM/1.5 (4818 en)
Memory Usage: 157 MB / 2730 MB (73 MB allocated, but free)
Java version: 1.6.0_30, Sun Microsystems Inc., Java HotSpot(TM) 64-Bit Server VM
Operating system: Windows 7
Dataset consistency test: No problems found

Plugin: OpeningHoursEditor (27355)
Plugin: buildings_tools (27355)
Plugin: imageryadjust (27355)
Plugin: licensechange (27472)
Plugin: mapdust (27355)
Plugin: measurement (27289)
Plugin: openstreetbugs (27355)
Plugin: restart (27289)
Plugin: reverter (27393)
Plugin: turnrestrictions (27355)
Plugin: undelete (27395)
Plugin: utilsplugin2 (27426)

[simon04]

Strange … Works fine here … I had this problem while developing, but it should be fixed now.

For investigating, could you please attach the file .josm/cache/bing.attribution.xml.

[rickmastfan67]

There you go.

Also, #7291 might be related to this.

[simon04]

Replying to rickmastfan67:

There you go.

This is in fact related to #7284, not this ticket.
Thank you. I don't understand why this problem occurs: The file contains the BOM (0xef 0xbb 0xbf), which should be handled by UTFInputStreamReader. Does this problem occur on other systems as well?

Also, #7291 might be related to this.

I don't see any connection to that issue.

[simon04]

Replying to simon04:

Replying to rickmastfan67:

There you go.

This is in fact related to #7284, not this ticket.
Thank you. I don't understand why this problem occurs: The file contains the BOM (0xef 0xbb 0xbf), which should be handled by UTFInputStreamReader. Does this problem occur on other systems as well?

I could track down the problem to some encoding issue under Windows. Should be fixed in [o27491].

[stoecker]

Are you sure it is a good idea to add a "ex.printStackTrace();" in library code?

[simon04]

In [4825/josm]:

see #7289 - remove JOSM specific stuff from jmapviewer

[simon04]

Replying to stoecker:

Are you sure it is a good idea to add a "ex.printStackTrace();" in library code?

Removed.

[rickmastfan67]

Replying to simon04:

Replying to simon04:

Replying to rickmastfan67:

There you go.

This is in fact related to #7284, not this ticket.
Thank you. I don't understand why this problem occurs: The file contains the BOM (0xef 0xbb 0xbf), which should be handled by UTFInputStreamReader. Does this problem occur on other systems as well?

I could track down the problem to some encoding issue under Windows. Should be fixed in [o27491].

It doesn't seem to be fully fixed. However, I'll continue in #7284 since you said the problem was related to that ticket.

[simon04]

Fixed in r8714.