Modify

Opened 14 years ago

Closed 13 years ago

Last modified 13 years ago

#7032 closed defect (fixed)

Regression: can't easily add tags to recently drawn way

Reported by: richlv Owned by: olejorgenb
Priority: major Milestone:
Component: Core Version:
Keywords: Cc:

Description

josm 4550. regression.

draw a way, press alt+a to add tags to it... selection gets changed and tags only added to the last node.

this worked ok, well, in nearly all previous versions :)
makes mapping highly, highly inconvenient (at least for me)

Attachments (1)

workaround7032.2.diff (2.2 KB ) - added by bastiK 13 years ago.

Download all attachments as: .zip

Change History (16)

comment:1 by Don-vip, 14 years ago

Priority: criticalmajor

Confirmed, regression introduced in r4539 (see #6853).

I lower priority as the workaround is obvious.

comment:2 by richlv, 14 years ago

hmm. not sure whether "cancel editing mode, select way again" counts as a workaround, but it's so inefficient, that for now i just downgraded to 4487 :)

comment:3 by Don-vip, 14 years ago

Owner: changed from team to olejorgenb

comment:4 by olejorgenb, 14 years ago

Ah.., that's a really unfortunate side effect I didn't think of. (I have mapped add-tag to 't') It's not easily fixable, as the goal of dynamic feedback based on the alt state kinda is in direct conflict with alt-based hotkeys depending on the selection. Using highlighting instead might work?

Other options is to completely roll back the patch or using version 1 (#6853) instead. Ie. just selecting the way to be extended when entering drawmode. (that was my primary motivation for the patch)

BTW: A better workaround is to end the way before adding the tags. Ie. double-click/clicking on the last added node. In that case the alt modifier wont mess with the selection.

comment:5 by anonymous, 14 years ago

i like the idea of selecting the way that will be extended - currently i have to carefully follow what happens after i draw first segment and potentially split & cleanup ways. but i like my alt+ shortcuts on unfinished ways even better :)
so i'd personally prefer "version 1", if i understood that it does correctly

comment:6 by richlv, 14 years ago

arr. i always forget to login. anonymous edits/comments should be prohibited here ;)

comment:7 by alv, 14 years ago

If I draw a way, the add tag button in the properties panel adds tags to the way; if I draw a new "one segment" way from some previous node with alt+click, the last node and is selected and once I release the alt key, it selects also the new way. In that case, the "add tag button" adds to both the way and the last node. In this case "double click to end" doesn't work, either (last node stays selected) - although if I then try to do another new way with alt+click, it thinks the last node isn't selected and doesn't add a way.

My common use case: have a fence, continues as a wall.

IMO highlighting would be better than selecting.

comment:8 by richlv, 13 years ago

pingity-ping. any chance of this regression being fixed ? i'm stuck in an older josm version now ;)

comment:9 by skyper, 13 years ago

Summary: can't easily add tags to recently drawn wayRegression: can't easily add tags to recently drawn way

+1

Please, this is annoying.

comment:10 by simon04, 13 years ago

Ticket #7583 has been marked as a duplicate of this ticket.

comment:11 by richlv, 13 years ago

can i bribe josm devels with beer to deal with this one ? maybe somebody visiting akademy in a few days ? :)

comment:12 by simon04, 13 years ago

A (temporary) workaround would be the option to disable the visual feedback on [Alt] (i.e., starting to draw a new way) in order to add tags to the way.

by bastiK, 13 years ago

Attachment: workaround7032.2.diff added

comment:13 by bastiK, 13 years ago

I've attached a possible workaround. The solution isn't all that great, but it fixes the problem.

comment:14 by bastiK, 13 years ago

Resolution: fixed
Status: newclosed

In 5378/josm:

fixed #7032 - can't easily add tags to recently drawn way

comment:15 by richlv, 13 years ago

wow, i don't know why i didn't get the update email about the last change... THANKS :)
confirming the fix in 5388 - i can finally upgrade josm ;)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain olejorgenb.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.