Modify

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#6883 closed enhancement (fixed)

property toggle dialog: possibility to select and perform actions on several entries at once.

Reported by: skyper Owned by: team
Priority: major Milestone:
Component: Core Version:
Keywords: property select Cc: joshdoe

Description (last modified by joshdoe)

I like to have a possibility to select several entries at the property toggle dialog and perform actions on them like delete, copy key/value ...

Have a look at #6857 for some background.

The best solution for "Edit" needs to be discussed. See ticket/6857

Thanks for your work !

r4453

Attachments (2)

delete_multiple_properties.diff (4.1 KB) - added by joshdoe 9 years ago.
allow deletion of multiple properties or tags
modify_multiple_properties_at_once.patch (11.6 KB) - added by joshdoe 9 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 9 years ago by stoecker

I think this was already requested in the past and I still feel that it would be much more dangerous to implement this than it would bring benefits. We improved the selection e.g. after delete, so deleting multiple elements most time means to press delete repeatedly.

comment:2 in reply to:  1 Changed 9 years ago by skyper

Replying to stoecker:

I think this was already requested in the past and I still feel that it would be much more dangerous to implement this than it would bring benefits. We improved the selection e.g. after delete, so deleting multiple elements most time means to press delete repeatedly.

Actually, important for me in first place would be a copy key+value action on several entries.

I notized that in the relations toggle dialog some actions are disabled when several entries (relations) are selected.

Changed 9 years ago by joshdoe

allow deletion of multiple properties or tags

comment:3 Changed 9 years ago by joshdoe

Cc: joshdoe added
Description: modified (diff)

I've been doing lots of TIGER clean up lately, and have been removing tiger: tags quite a bit. So I made the attached patch to allow deleting multiple properties (tags). This is related to the now closed #1478 and #1752.

comment:4 Changed 9 years ago by bastiK

In [4697/josm]:

see #6883 - property toggle dialog: possibility to select and perform actions on several entries at once. (patch by joshdoe)

comment:5 Changed 9 years ago by bastiK

I don't see how this is dangerous. You normally don't select multiple properties, and it is pretty clear and straight forward behaviour anyway.

comment:6 in reply to:  5 ; Changed 9 years ago by joshdoe

Replying to bastiK:

I don't see how this is dangerous. You normally don't select multiple properties, and it is pretty clear and straight forward behaviour anyway.

I'd agree. One thing I'm not sure about though is that right now multiple commands are issued for the deletion, so if you delete 10 tags than you'd have to run the undo command 10 times. Should I implement a new command that deletes multiple tags?

comment:7 in reply to:  6 Changed 9 years ago by skyper

Replying to joshdoe:

Replying to bastiK:

I don't see how this is dangerous. You normally don't select multiple properties, and it is pretty clear and straight forward behaviour anyway.

I think the normal focus behaviour (click to focus) is much more dangerous. At least speaking for myself. See comment:12:ticket:3278

I'd agree. One thing I'm not sure about though is that right now multiple commands are issued for the deletion, so if you delete 10 tags than you'd have to run the undo command 10 times. Should I implement a new command that deletes multiple tags?

This way you might be able to only undo some changes. (You can always undo many steps at once in the command stack dialog.)

Only real problem, I see is with un/redo.

Changed 9 years ago by joshdoe

comment:8 Changed 9 years ago by stoecker

Summary: property toggle dialog: possibility to select and perform actions on several entries at once.[patch] property toggle dialog: possibility to select and perform actions on several entries at once.

comment:9 Changed 9 years ago by joshdoe

Thanks for committing the patch bastiK.

The above patch (attachment:modify_multiple_properties_at_once.patch) modifies ChangePropertyCommand to support modifying (including deleting) multiple properties of multiple objects at once (creating just one command instead of multiple commands as now). This improves speed when deleting many tags (e.g. TIGER tags) on many objects, since each object is only iterated over once and begin/endUpdate() is only executed once. The patch also uses this command when deleting multiple properties, which is why I am attaching this here.

I tried to reduce redundant code as much as possible, but if it is preferred to have a dedicated code path for deleting single properties let me know.

comment:10 Changed 9 years ago by bastiK

Resolution: fixed
Status: newclosed

In [4773/josm]:

applied #6883 - property toggle dialog: possibility to select and perform actions on several entries at once. (patch by joshdoe)

comment:11 Changed 9 years ago by joshdoe

Summary: [patch] property toggle dialog: possibility to select and perform actions on several entries at once.property toggle dialog: possibility to select and perform actions on several entries at once.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.