Modify

Opened 8 years ago

Closed 5 years ago

Last modified 5 years ago

#6881 closed enhancement (fixed)

[Patch] Add tagging template for key "smoothness"

Reported by: Bernhard Hiller <bhil@…> Owned by: ce
Priority: normal Milestone: 15.02
Component: Internal preset Version: tested
Keywords: Cc: skyper, Klumbumbus

Description

The key "smoothness" is described in http://wiki.openstreetmap.org/wiki/Key:smoothness. It is not yet (as of version 4279) available among the templates in JOSM.

Attachments (2)

defaultpresets.zip (28.4 KB) - added by bhil@… 8 years ago.
Patch for internal presets
6881.patch (10.5 KB) - added by simon04 8 years ago.
patch as patch for easier reviewing

Download all attachments as: .zip

Change History (21)

comment:1 Changed 8 years ago by simon04

Component: CoreInternal preset
Owner: changed from team to ce

comment:2 Changed 8 years ago by simon04

According to the Wiki page, the usage of this tag is discussed controversially. The internal presets already contain the tag surface, which has similar meaning.

Thus, I personally vote against adding smoothness to the presets.

comment:3 in reply to:  2 Changed 8 years ago by Bernhard Hiller <bhil@…>

Replying to simon04:
"surface=asphalt" can mean anything between the surface of a newly built motorway and a rotten potholed road.
Since "surface", "tracktype", and "smoothness" are not at all unified (yet), this tag is (still) useful.

comment:4 Changed 8 years ago by Bernhard Hiller <bhil@…>

Please find enclosed my changes to defaultpresets.xml. Hope this is the correct position for adding a new se, at least it works when I debug the program.
I found that for "highway=track" the surface-collection was smaller than for other ways; I changed that, too.

Changed 8 years ago by bhil@…

Attachment: defaultpresets.zip added

Patch for internal presets

Changed 8 years ago by simon04

Attachment: 6881.patch added

patch as patch for easier reviewing

comment:5 Changed 8 years ago by simon04

Summary: Add tagging template for key "smoothness"[Patch] Add tagging template for key "smoothness"

comment:6 in reply to:  2 Changed 8 years ago by bastiK

Replying to simon04:

Thus, I personally vote against adding smoothness to the presets.

+1

Some people may have the urge to fill in the preset form completely. So it looks like it is somehow mandatory to specify a smoothness value for each highway. We could place it somewhere less prominent, possible in a user preset.

In addition, the plain values are misleading - you need the full definition to tag it properly. One can use display_values like for SAC scale.

comment:7 Changed 8 years ago by stoecker

Resolution: wontfix
Status: newclosed

comment:8 Changed 5 years ago by przemas75

Resolution: wontfix
Status: closedreopened

There are quite a lot of smoothness tag in the database, are you still oppose this tag in JOSM?

comment:9 Changed 5 years ago by bastiK

I've asked for opinions on the tagging mailing list:

https://lists.openstreetmap.org/pipermail/tagging/2014-August/019193.html

comment:10 Changed 5 years ago by bastiK

This seems to be the sentiment shared by most:

Mateusz on Tagging:

I use smoothness and I would welcome it in JOSM. I am not really happy
about it, but I was unable to invent something better and it
not as bad as say maxspeed:practical.

smoothness=* is supported in iD: https://lists.openstreetmap.org/pipermail/tagging/2014-August/019197.html

Overall I would revise my opinion from 3 years ago and vote for the inclusion of this tag.

comment:11 Changed 5 years ago by skyper

Cc: skyper added

comment:12 Changed 5 years ago by Klumbumbus

Cc: Klumbumbus added

comment:13 Changed 5 years ago by Klumbumbus

Resolution: fixed
Status: reopenedclosed

In 8028/josm:

fix #6881 - add smoothness combos to presets. (descriptions from https://github.com/openstreetmap/iD/blob/master/data/presets/fields/smoothness.json)

comment:14 Changed 5 years ago by Klumbumbus

Milestone: 15.02

comment:15 Changed 5 years ago by bastiK

Thanks!

comment:16 Changed 5 years ago by anonymous

Can these strings have context for translation please? They already clash with the same values for path visibility.

comment:17 Changed 5 years ago by Klumbumbus

In 8039/josm:

see #6881 - allow smoothness parking combination in validator

comment:18 in reply to:  16 Changed 5 years ago by Klumbumbus

Replying to anonymous:

Can these strings have context for translation please? They already clash with the same values for path visibility.

trail_visibility already has a translation context, so they are handled separately.

#. item "Ways/Path" combo "Visibility" display value
#: build/trans_presets.java:875
msgctxt "trail_visibility"
msgid "excellent"
msgstr "exzellent"

...

#. item  combo "Smoothness" entry "excellent" display value
#: build/trans_presets.java:21
msgid "excellent"
msgstr ""

comment:19 Changed 5 years ago by aceman

Ok, thanks.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain ce.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.