Modify

Opened 9 years ago

Last modified 4 months ago

#6836 new defect

unglue way: only keep memberships of turn restriction if selected way is part of.

Reported by: skyper Owned by: team
Priority: major Milestone:
Component: Core Version:
Keywords: unglue turn relation from via to Cc: simon04

Description (last modified by skyper)

If I unglue a way at a node with role=via in turn restrictions its memberships are copied to the new node which breaks all turn relations (warning needed) and is wrong if the selected and unglued way is not part of the relation.

Please do not copy the node's memberships if the way is not part of the relation and warn if it is because user has to solve the problem manually.

r4419

Thanks

Attachments (2)

6836.osm (7.6 KB) - added by Don-vip 10 months ago.
6836.patch (2.6 KB) - added by GerdP 4 months ago.

Download all attachments as: .zip

Change History (18)

comment:1 Changed 7 years ago by skyper

Description: modified (diff)

This is really annoying.

comment:2 Changed 7 years ago by skyper

Resolution: duplicate
Status: newclosed

Closed as duplicate of #4635.

comment:3 Changed 10 months ago by Don-vip

Keywords: from via to added
Resolution: duplicate
Status: closedreopened
Type: enhancementdefect

#4635 was about split, which works correctly. Unglue has indeed a problem.

Changed 10 months ago by Don-vip

Attachment: 6836.osm added

comment:4 Changed 4 months ago by GerdP

I wonder how you can unglue such a node without breaking the turn restrictions?

comment:5 Changed 4 months ago by GerdP

Owner: changed from team to skyper
Status: reopenedneedinfo

comment:6 Changed 4 months ago by GerdP

Ah, in your example one can unglue way 453764535 as it is not part of a restriction relation.
I think the popup introduced for #8838 is the solution for this problem, right?
Fixed?

Last edited 4 months ago by GerdP (previous) (diff)

comment:7 Changed 4 months ago by skyper

No the popup should not be shown for w453764535 as it has nothing to do with the relations and the only solution is to not copy but keep the memberships on the existing node to not break the relations. Issue is similar or even the same as in #18670 but with a different type with own treatment.

For the other ways the situation is fixed.

comment:8 Changed 4 months ago by skyper

Owner: changed from skyper to team
Status: needinfonew

comment:9 in reply to:  7 Changed 4 months ago by skyper

Replying to skyper:

No the popup should not be shown for w453764535

Sorry, the popup should only show the tag part. E.g. delete all tags from node first and then unglue should not show a popup.

comment:10 Changed 4 months ago by GerdP

Cc: simon04 added

I agree. In what situation do we actually want to add the membership to the new (or both) nodes? Was introduced for #8838.
Up to now I can only think of type=site relations which would not be broken.

comment:11 in reply to:  10 Changed 4 months ago by skyper

Replying to GerdP:

I agree. In what situation do we actually want to add the membership to the new (or both) nodes? Was introduced for #8838.
Up to now I can only think of type=site relations which would not be broken.

I know relations for TMC Points, Old german import scheme and TMC Point, plus node relations.
I am not sure about enforcement.

comment:12 Changed 4 months ago by GerdP

OK, so we cannot remove that option. The current code shows the dialog before it is known that none of the relations will be changed. Not easy to change that.

comment:13 Changed 4 months ago by GerdP

Not easy to change that.

Unless we simply say that the dialog should ignore memberships where the role is "via".

comment:14 in reply to:  13 Changed 4 months ago by skyper

Replying to GerdP:

OK, so we cannot remove that option. The current code shows the dialog before it is known that none of the relations will be changed. Not easy to change that.

No, please, do not remove the code!
Replying to GerdP:

Not easy to change that.

Unless we simply say that the dialog should ignore memberships where the role is "via".

That is the way to go, handle known types, properly, either by role or relation type or even both.

Changed 4 months ago by GerdP

Attachment: 6836.patch added

comment:15 Changed 4 months ago by GerdP

The patch changes the code which check the selected node(s) so that memberships in type=restriction or type=connectivity relations are ignored as well as memberships where the role is "via". If any membership is found which doesn't match these criteria the dialog "Where should the memberships of this node be put?" is shown.

There are probably more relation types and roles, but I think those should be handled in new tickets.

comment:16 Changed 4 months ago by GerdP

This needs more thinking. See related ticket:18670#comment:6

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to skyper
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.