Modify

Opened 14 years ago

Closed 12 years ago

Last modified 12 years ago

#6633 closed defect (fixed)

Needless 'No conflicts to resolve' dialog

Reported by: pinkduck Owned by: team
Priority: normal Milestone: 14.01
Component: Core Version: tested
Keywords: TagConflictResolver, combine, dialog Cc:

Description (last modified by Don-vip)

I have the following two preferences set in JOSM:

org.openstreetmap.josm.gui.conflict.tags.TagConflictResolver.showTagsWithConflictsOnly=true
org.openstreetmap.josm.gui.conflict.tags.TagConflictResolver.showTagsWithMultiValuesOnly=true

See the attached Demonstration.osm file for a particular arrangement where trying to combine three ways into a closed way building shape results in a dialogue stating 'No conflicts to resolve'.

Way 1: building=yes
Way 2: building=yes
Way 3: untagged

I do not believe the 'No conflicts to resolve' dialogue should be shown in this case. If the separate ways with building=yes are combined first and then combined with the remaining untagged way the dialogue is not shown, so what is special about the 3-way case?

It is quite a nuisance to have to dismiss this dialogue hundreds of times when splitting and rejoining building outlines into individual addresses.

Attachments (1)

Demonstration.osm (849 bytes ) - added by pinkduck 14 years ago.
Simple test case to demonstrate issue

Download all attachments as: .zip

Change History (6)

by pinkduck, 14 years ago

Attachment: Demonstration.osm added

Simple test case to demonstrate issue

comment:1 by pinkduck, 14 years ago

Description: modified (diff)

comment:2 by skyper, 14 years ago

I even get a dialog when combining two ways with exact the same tags if they are part of at least on relation (Just cut a way and combine it again).

r4261

Last edited 14 years ago by skyper (previous) (diff)

comment:3 by Don-vip, 12 years ago

Description: modified (diff)
Milestone: 14.01

comment:4 by Don-vip, 12 years ago

Resolution: fixed
Status: newclosed

In 6715/josm:

fix #6633 - Needless 'No conflicts to resolve' dialog

comment:5 by pinkduck, 12 years ago

Thank you so much Don-vip for fixing these long-standing issues with JOSM.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.