Improve the Upload Window

[Casiope]

The Upload Window needs a rework. I rewrite some sentences but I'm unable to make the code. Someone need to help me for that! :)

/* If 1 new changeset & no comment & 1 request: */
"<strong>{0} object</strong> is uploaded to <strong>a new changeset</strong> using <strong>1 request</strong>."
"<strong>{0} objects</strong> are uploaded to <strong>a new changeset</strong> using <strong>1 request</strong>."

/* If 1 new changeset & comment & 1 request: */
"<strong>{0} object</strong> is uploaded to <strong>a new changeset</strong> with comment ''{2}'' using <strong>1 request</strong>."
"<strong>{0} objects</strong> are uploaded to <strong>a new changeset</strong> with comment ''{2}'' using <strong>1 request</strong>."

/* If 1 new changeset & no comment & many requests: */
"<strong>{0} objects</strong> are uploaded to <strong>a new changeset</strong> using <strong>{3} requests</strong>."

/* If 1 new changeset & comment & many requests: */
"<strong>{0} objects</strong> are uploaded to <strong>a new changeset</strong> with comment ''{2}'' using <strong>{3} requests</strong>."

/* If 1 old changeset & no comment & 1 request: */
"<strong>{0} object</strong> is uploaded to <strong>the open changeset {1}</strong> using <strong>1 request</strong>."
"<strong>{0} objects</strong> are uploaded to <strong>the open changeset {1}</strong> using <strong>1 request</strong>."

/* If 1 old changeset & comment & 1 request: */
"<strong>{0} object</strong> is uploaded to <strong>the open changeset {1}</strong> with comment ''{2}'' using <strong>1 request</strong>."
"<strong>{0} objects</strong> are uploaded to <strong>the open changeset {1}</strong> with comment ''{2}'' using <strong>1 request</strong>."

/* If 1 old changeset & no comment & many requests: */
"<strong>{0} objects</strong> are uploaded to <strong>the open changeset {1}</strong> using <strong>{3} requests</strong>."

/* If 1 old changeset & comment & many requests: */
"<strong>{0} objects</strong> are uploaded to <strong>the open changeset {1}</strong> with comment ''{2}'' using <strong>{3} requests</strong>."

/* If many changesets & no comment & many requests: */
"<strong>{0} objects</strong> are uploaded to <strong>multiple changesets</strong> using <strong>{3} requests</strong>."

/* If many changesets & comment & many requests: */
"<strong>{0} objects</strong> are uploaded to <strong>multiple changesets</strong> with comment ''{2}'' using <strong>{3} requests</strong>."


/* If no comment --> New window with warning about comment */
/* If many objects are uploaded --> show the ligne "advanced configuration" */
/* Either (1 object is uploaded) --> Hide the line "advanced configuration" */


/* If 1 changeset & changeset is closed after upload: */
"The changeset is going to be <strong>closed</strong> after this upload."

/* If 1 changeset & changeset is open after upload: */
"The changeset is <strong>left open</strong> after this upload."

/* If many changesets & changesets are closed after upload: */
"The changesets are going to be <strong>closed</strong> after this upload."

/* If many changeset & changesets are open after upload: */
"The changesets are <strong>left open</strong> after this upload."

[simon04]

I tried to format the description to increase readability.

[simon04]

If I see it correctly, your improvement boils down to the following (not easy to see that, though):

1. echoing the comment
2. combining the number and type (new/open) of changeset
3. printing "The changesets are going to be [...]" in case of multiple changesets

Is that correct?

My thoughts:

• Number 1: I don't see the point in printing the comment as (a) the comment is in the text field above anyway, and (b) comments can be very long.
• Number 2: No strict opinion on that. Currently, one gets the some numbers in the first part and the information about what is happening to the changeset in the second part.
• Number 3 is more a cosmetic change, but is very easy to do.

[Casiope]

I added an image to explain better.

[skyper]

The Settings dialog was changed and reflect almost all suggestions. The "Advanced" tab still offers all options with only one object to upload. This tab should be completely disabled with only one object to upload.

[simon04]

What's left to be done after the changes in #20708?