Modify

Opened 13 years ago

Closed 12 years ago

#6584 closed defect (fixed)

OpeningHoursEditor does not capture right mouse click

Reported by: Pepou Owned by: boman
Priority: normal Milestone:
Component: Plugin openinghourseditor Version: latest
Keywords: Cc:

Description (last modified by boman)

wiki:JOSM/Plugins/OpeningHoursEditor says that "By clicking right on a rectangle you can choose 'open end' the color of the rectangle becomes red."

The problem is that right-clicking a rectangle does nothing. Therefore it is neither possible to make some time-span be open-end, nor it is possible to remove this attribute from some red rectangle (if the value already contained e.g. "Sa 19:00+" prior to opening the plugin dialog). Manual string editing is necessary.

Attachments (0)

Change History (4)

comment:1 by boman, 13 years ago

The problem with right click:
On my System with "Linux Mint (katya)" and OpenJDK the popup-menu is there by clicking with the right mouse on a rectangle.
Maybe you could add more info about your System. Helpfull would be the complete status overview (from the JOSM helpmenu).

I'm not sure if you know that text editing is possible. You must press enter after changing something in the textfield.
I should somehow change this behaviour, because it is confusing.

in reply to:  1 comment:2 by Pepou, 13 years ago

Replying to boman:

The problem with right click:
On my System with "Linux Mint (katya)" and OpenJDK the popup-menu is there by clicking with the right mouse on a rectangle.
Maybe you could add more info about your System.

My system is Win7 x64 Home Premium SP1, JOSM 4223, Java 1.6.0_25, OpeningHoursEditor 26284, +some other plugins.

I can move (or extend/shrink) both rectangle types (e.g. "Sa 20:00+; Su 20:00-23:00") with mouse, but right mouse click simply does not show any reaction. I have no idea why (if it's my system's fault).

I'm not sure if you know that text editing is possible. You must press enter after changing something in the textfield. I should somehow change this behaviour, because it is confusing.

I'm aware of this, as I wrote, "Manual string editing is necessary". With the "confusing" you are right, or, maybe some indication of pending editing (an underlying color?) would be sufficient.

I've got a few more ideas and shifted them from this comment into ticket #6656.

Helpfull would be the complete status overview (from the JOSM helpmenu).

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2011-07-11 01:31:35
Last Changed Author: stoecker
Revision: 4223
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2011-07-10 22:46:41 +0200 (Sun, 10 Jul 2011)
Last Changed Rev: 4223

Identification: JOSM/1.5 (4223 sk)
Memory Usage: 59 MB / 455 MB (22 MB allocated, but free)
Java version: 1.6.0_25, Sun Microsystems Inc., Java HotSpot(TM) 64-Bit Server VM
Operating system: Windows 7

Plugin: DirectDownload (26174)
Plugin: ElevationProfile (26174)
Plugin: OpeningHoursEditor (26284)
Plugin: buildings_tools (26254)
Plugin: openstreetbugs (26299)
Plugin: turnlanes (26316)
Plugin: turnrestrictions (26299)

cache.geoimage-thumbnails.expire=-1
cache.geoimage-thumbnails.maxsize=120
cache.motd.html=1311582617
cache.motd.html.lang=Sk:
cache.motd.html.version=4223
changeset-query.advanced.time-restrictions.query-type=closed-after
changesetdialog.minimized=true
color.Imagery fade=#FFFFFF
color.layer W20110629140638_1_.gpx=#00FFFF
color.layer W20110629150750_1_.gpx=#FF33CC
color.layer W20110716210715.gpx=#00CCCC
conflict.visible=true
coordinates=DEGREES_MINUTES_SECONDS
draw.rawgps.colorTracksTune=10
draw.rawgps.colors=1
draw.rawgps.lines.layer 20100713-1200-nmea.txt=true
elevation.visible=false
geoimage.bounds=924,507,650,375
geoimage.docked=false
geoimage.showThumbs=true
geoimage.timezone=+0:00
gpxLayer.downloadAlongTrack.area=3
gpxLayer.downloadAlongTrack.distance=2
gpxLayer.downloadAlongTrack.near=2
gui.geometry=1616x916+0+292
gui.maximized=true
josm.version=4223
mappaint.renderer-class-name=org.openstreetmap.josm.data.osm.visitor.paint.StyledMapRenderer
mappaint.style.known-defaults=resource://styles/standard/elemstyles.xml
resource://styles/standard/potlatch2.mapcss
mappaint.style.sources-list.0=resource://styles/standard/potlatch2.mapcss
standard
Potlatch 2
true
mappaint.style.sources-list.1=resource://styles/standard/elemstyles.xml
standard
JOSM Internal Style
false
mappaint.style.sources-list.2=http://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&style

Maxspeed
true
mappaint.style.sources-list.3=http://josm.openstreetmap.de/josmfile?page=Styles/MaxspeedIcons&zip=1

Speedlimit Signs
true
mappaint.style.sources-list.4=http://josm.openstreetmap.de/josmfile?page=Styles/Modified&style

Modified objects
true
mappaint.style.sources-list.5=http://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&style

Parking lanes
true
mappaint.style.sources-list.6=http://josm.openstreetmap.de/josmfile?page=Styles/Surface&style

Surface
false
mappaint.style.sources-list.7=http://josm.openstreetmap.de/josmfile?page=Styles/Lit&style

Lit
true
marker.audiofromstart=false
marker.buttonlabels=false
message.delete_from_relation.value=2
message.movedManyElements.value=1
mirror.http://josm.openstreetmap.de/josmfile?page_Presets/Crafts&preset=1311675035017
C:\...\JOSM\mirror_http___josm.openstreetmap.de_josmfile_page_Presets_Crafts_preset
mirror.http://josm.openstreetmap.de/josmfile?page_Presets/NewTags&zip_1=1311611513949
C:\...\JOSM\mirror_http___josm.openstreetmap.de_josmfile_page_Presets_NewTags_zip_1
mirror.http://josm.openstreetmap.de/josmfile?page_Presets/OneClick&zip_1=1311673772994
C:\...\JOSM\mirror_http___josm.openstreetmap.de_josmfile_page_Presets_OneClick_zip_1
mirror.http://josm.openstreetmap.de/josmfile?page_Presets/OpenPisteMap&preset=1311611513422
C:\...\JOSM\mirror_http___josm.openstreetmap.de_josmfile_page_Presets_OpenPisteMap_preset
mirror.http://josm.openstreetmap.de/josmfile?page_Styles/Lit&style=1311609327733
C:\...\JOSM\mirror_http___josm.openstreetmap.de_josmfile_page_Styles_Lit_style
mirror.http://josm.openstreetmap.de/josmfile?page_Styles/Maxspeed&style=1311582616094
C:\...\JOSM\mirror_http___josm.openstreetmap.de_josmfile_page_Styles_Maxspeed_style
mirror.http://josm.openstreetmap.de/josmfile?page_Styles/MaxspeedIcons&zip_1=1311582613134
C:\...\JOSM\mirror_http___josm.openstreetmap.de_josmfile_page_Styles_MaxspeedIcons_zip_1
mirror.http://josm.openstreetmap.de/josmfile?page_Styles/Modified&style=1311582613277
C:\...\JOSM\mirror_http___josm.openstreetmap.de_josmfile_page_Styles_Modified_style
mirror.http://josm.openstreetmap.de/josmfile?page_Styles/ParkingLanes&style=1311609327262
C:\...\JOSM\mirror_http___josm.openstreetmap.de_josmfile_page_Styles_ParkingLanes_style
mirror.http://josm.openstreetmap.de/josmfile?page_Styles/Surface&style=1311609327427
C:\...\JOSM\mirror_http___josm.openstreetmap.de_josmfile_page_Styles_Surface_style
mirror.http://josm.openstreetmap.de/maps=1311582616498
C:\...\JOSM\mirror_http___josm.openstreetmap.de_maps
mirror.http://josm.openstreetmap.de/presets=1311673579224
C:\...\JOSM\mirror_http___josm.openstreetmap.de_presets
mirror.http://josm.openstreetmap.de/styles=1311609202208
C:\...\JOSM\mirror_http___josm.openstreetmap.de_styles
mirror.http://osm.sebastian-klemm.eu/josm/josm-preset_parkinglane.xml=1311606651147
C:\...\JOSM\mirror_http___osm.sebastian-klemm.eu_josm_josm-preset_parkinglane.xml
mirror.http://osmtools.de/josm/steps.xml=1311675035267
C:\...\JOSM\mirror_http___osmtools.de_josm_steps.xml
mirror.http://planet.openstreetmap.org/users_agreed/users_agreed.txt=1310553013794
C:\...\JOSM\mirror_http___planet.openstreetmap.org_users_agreed_users_agreed.txt
mirror.http://planet.openstreetmap.org/users_agreed/users_disagreed.txt=1310553014000
C:\...\JOSM\mirror_http___planet.openstreetmap.org_users_agreed_users_disagreed.txt
mirror.http://somewhere.dk/email/josm/source.xml=1311611498221
C:\...\JOSM\mirror_http___somewhere.dk_email_josm_source.xml
mirror.http://www.schoenitzer.de/test/pavement.xml=1311611499471
C:\...\JOSM\mirror_http___www.schoenitzer.de_test_pavement.xml
mirror.images.http://github.com/Nudin/OSM/raw/master/presets/pavement.png=1311611499772
C:\...\JOSM\images\mirror_http___github.com_Nudin_OSM_raw_master_presets_pavement.png
mirror.images.http://osmtools.de/josm/steps.png=1311675035324
C:\...\JOSM\images\mirror_http___osmtools.de_josm_steps.png
mirror.images.http://osmtools.de/josm/steps_dialog.png=1311675035399
C:\...\JOSM\images\mirror_http___osmtools.de_josm_steps_dialog.png
mirror.images.http://osmtools.de/josm/steps_oneclick.png=1311675035496
C:\...\JOSM\images\mirror_http___osmtools.de_josm_steps_oneclick.png
mirror.images.http://somewhere.dk/email/josm/note.png=1311611498587
C:\...\JOSM\images\mirror_http___somewhere.dk_email_josm_note.png
mirror.images.http://somewhere.dk/email/josm/note_accept.png=1311611498789
C:\...\JOSM\images\mirror_http___somewhere.dk_email_josm_note_accept.png
mirror.images.http://somewhere.dk/email/josm/note_add.png=1311611498897
C:\...\JOSM\images\mirror_http___somewhere.dk_email_josm_note_add.png
mirror.images.http://somewhere.dk/email/josm/note_add_bing.png=1311611499033
C:\...\JOSM\images\mirror_http___somewhere.dk_email_josm_note_add_bing.png
mirror.images.http://somewhere.dk/email/josm/note_add_fugro.png=1311611499209
C:\...\JOSM\images\mirror_http___somewhere.dk_email_josm_note_add_fugro.png
org.openstreetmap.josm.gui.actionsupport.DeleteFromRelationConfirmationDialog.geometry=x=829,y=561,width=400,height=200
org.openstreetmap.josm.gui.conflict.tags.CombinePrimitiveResolverDialog.geometry=x=551,y=250,width=600,height=400
org.openstreetmap.josm.gui.dialogs.changeset.query.ChangesetQueryDialog.geometry=x=564,y=287,width=400,height=400
org.openstreetmap.josm.gui.dialogs.relation.GenericRelationEditor.geometry=x=998,y=452,width=700,height=650
org.openstreetmap.josm.gui.download.DownloadDialog.geometry=x=309,y=243,width=1000,height=600
org.openstreetmap.josm.gui.help.HelpBrowser.geometry=x=102,y=0,width=732,height=500
org.openstreetmap.josm.gui.io.CloseChangesetDialog.geometry=x=861,y=450,width=517,height=300
org.openstreetmap.josm.gui.io.UploadDialog.geometry=x=1002,y=319,width=400,height=816
org.openstreetmap.josm.gui.io.UploadSelectionDialog.geometry=x=911,y=400,width=453,height=699
org.openstreetmap.josm.gui.oauth.OAuthAuthorizationWizard.geometry=x=255,y=473,width=450,height=540
org.openstreetmap.josm.gui.preferences.PreferenceDialog.geometry=x=316,y=221,width=880,height=849
osb.api.disabled=false
osb.auto_download=true
osb.include_date=true
osb.uri.close=http://openstreetbugs.schokokeks.org/api/0.1/closePOIexec
osb.uri.download=http://openstreetbugs.schokokeks.org/api/0.1/getBugs
osb.uri.edit=http://openstreetbugs.schokokeks.org/api/0.1/editPOIexec
osb.uri.new=http://openstreetbugs.schokokeks.org/api/0.1/addPOIexec
osm-download.bounds=48.210315699999995;17.153573599999998;48.2109743;17.154885999999998
osm-server.upload-strategy=singlerequest
pluginmanager.lastupdate=1310485460620
pluginmanager.time-based-update.interval=20
pluginmanager.version=4223
plugins=DirectDownload
ElevationProfile
OpeningHoursEditor
buildings_tools
openstreetbugs
turnlanes
turnrestrictions
progressdialog.size=565
propertiesdialog.bounds=1069,440,346,188
proxy.policy=no-proxy
relationlist.minimized=true
relationlist.visible=true
selectionlist.bounds=840,506,342,188
shortcut.groups.1=128
shortcut.groups.10=64
shortcut.groups.11=576
shortcut.groups.12=64
shortcut.groups.13=512
shortcut.groups.15=640
shortcut.groups.16=640
shortcut.groups.17=576
shortcut.groups.18=512
shortcut.groups.19=128
shortcut.groups.2=128
shortcut.groups.20=512
shortcut.groups.3=0
shortcut.groups.4=512
shortcut.groups.5=0
shortcut.groups.6=512
shortcut.groups.8=192
shortcut.groups.9=192
shortcut.groups.configured=true
shortcut.shortcut.0=subwindow:mappaint;Prepnúť: MapPaint;77;4;77;576;false;true
taggingpreset.sources-list.0=resource://data/defaultpresets.xml
Internal Preset
taggingpreset.sources-list.1=http://osm.sebastian-klemm.eu/josm/josm-preset_parkinglane.xml
Parking lanes
taggingpreset.sources-list.2=http://somewhere.dk/email/josm/source.xml
Source properties
taggingpreset.sources-list.3=http://josm.openstreetmap.de/josmfile?page=Presets/OpenPisteMap&preset
Presets for OpenPisteMap
taggingpreset.sources-list.4=http://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
New Tags
taggingpreset.sources-list.5=http://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1
One click settings
taggingpreset.sources-list.6=http://josm.openstreetmap.de/josmfile?page=Presets/Crafts&preset
Presets for Crafts
taggingpreset.sources-list.7=http://osmtools.de/josm/steps.xml
Steps properties
toggleDialogs.width=326
toolbar=open
save
download
upload
|
undo
redo
|
dialogs/search(searchExpression=)
preference
|
splitway
combineway
wayflip
|
imagery-offset
|
tagginggroup_Highways/Streets
tagginggroup_Highways/Ways
tagginggroup_Highways/Waypoints
tagginggroup_Highways/Barriers
|
tagginggroup_Transport/Car
tagginggroup_Transport/Public Transport
|
tagginggroup_Facilities/Tourism
tagginggroup_Facilities/Food+Drinks
|
tagginggroup_Man Made/Historic Places
|
tagginggroup_Man Made/Man Made
turnlanes.png.bounds=2013,429,883,649
turnlanes.png.minimized=true
turnlanes.png.visible=true
turnrestrictions.edit-shortcut=shift ctrl pressed T
turnrestrictions.minimized=true
turnrestrictions.visible=true
upload.comment.last-used=1311613317
validator.tests=Coastlines=true,MultipolygonTest=true,SimilarNamedWays=true,UntaggedNode=true,RelationChecker=true,DuplicateRelation=true,CrossingWays=true,NodesWithSameName=true,TagChecker=true,OverlappingWays=true,UnclosedWays=true,WronglyOrderedWays=true,UnconnectedWays=true,SelfIntersectingWay=true,DuplicatedWayNodes=true,NameMismatch=true,DuplicateWay=true,UntaggedWay=true,TurnrestrictionTest=true,DuplicateNode=true
validator.testsBeforeUpload=Coastlines=true,MultipolygonTest=true,SimilarNamedWays=true,UntaggedNode=true,RelationChecker=true,DuplicateRelation=true,CrossingWays=true,NodesWithSameName=true,TagChecker=true,OverlappingWays=true,UnclosedWays=true,WronglyOrderedWays=true,UnconnectedWays=true,SelfIntersectingWay=true,DuplicatedWayNodes=true,NameMismatch=true,DuplicateWay=true,UntaggedWay=true,TurnrestrictionTest=true,DuplicateNode=true
validator.visible=true

comment:3 by boman, 12 years ago

Description: modified (diff)
Owner: changed from team to boman
Status: newassigned

I could reproduce the problem with the non-appearing menu on Win7.
I will try to find the bug.

comment:4 by boman, 12 years ago

Resolution: fixed
Status: assignedclosed

fixed in Changeset [o26838]

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain boman.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.