Modify

Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#6547 closed defect (fixed)

[patch] line height in relation editor is too big

Reported by: flaimo Owned by: team
Priority: normal Milestone:
Component: Core Version: tested
Keywords: relation font height Cc:

Description (last modified by Don-vip)

on a mac the line height in the relation editor is to high. on small screens this results in scrolling orgies. (see picture). line height was ok with 4064

version: 4201 on mac os x


Attachments (3)

Screen shot 2011-07-05 at 21.36.38.png (113.6 KB) - added by flaimo 8 years ago.
6547.patch (2.9 KB) - added by Hojoe 8 years ago.
initialize the cell editors with a small (1 pixel) empty border
6547-2.patch (3.0 KB) - added by Hojoe 8 years ago.
reworked

Download all attachments as: .zip

Change History (15)

Changed 8 years ago by flaimo

comment:1 Changed 8 years ago by flaimo

Summary: line height in relation editor it to bigline height in relation editor is to big

comment:2 Changed 8 years ago by flaimo

Summary: line height in relation editor is to bigline height in relation editor is too big

comment:3 Changed 8 years ago by Hojoe

This is the result of the fix for #4948. Before this fix the row was to small for the cell editor.

comment:4 Changed 8 years ago by flaimo

that might be true, that sometimes the line height was too narrow in earlier versions, but that is no a reason to overshoot it by effectively doubling the line height. that is just a waste of screen estate. why don't you do it like in the normal tags editor in the right side pane? the cell height seems to be fine there to display all letters.

comment:5 in reply to:  4 Changed 8 years ago by anonymous

Replying to flaimo:

why don't you do it like in the normal tags editor in the right side pane? the cell height seems to be fine there to display all letters.

The table of the tags editor isn't editable. The rows dosn't need to reserve space for a cell editor.

I will limit the border size of the cell editor.

Changed 8 years ago by Hojoe

Attachment: 6547.patch added

initialize the cell editors with a small (1 pixel) empty border

comment:6 Changed 8 years ago by Hojoe

Summary: line height in relation editor is too big[patch] line height in relation editor is too big

comment:7 Changed 8 years ago by stoecker

Resolution: fixed
Status: newclosed

In [4215/josm]:

fix #6547 - patch by Hojoe - reduce space usage in relation editor

comment:8 Changed 8 years ago by stoecker

In [4223/josm]:

fix #6570 (revert change in r4215, see #6547), i18n update, fix typo in function names

comment:9 Changed 8 years ago by stoecker

Resolution: fixed
Status: closedreopened

Changed 8 years ago by Hojoe

Attachment: 6547-2.patch added

reworked

comment:10 Changed 8 years ago by Hojoe

Sorry, I looked, but I didn't see the cell editor from the column model. Now the patch (6547-2.patch) reuse the the existing cell editor to change the border of the text field.

comment:11 Changed 8 years ago by stoecker

Resolution: fixed
Status: reopenedclosed

In [4238/josm]:

fix #6547 - patch by Hojoe - line height in relation editor too high

comment:12 Changed 5 years ago by Don-vip

Description: modified (diff)
Keywords: relation font height added

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.