Modify

Opened 9 years ago

Closed 6 years ago

#6039 closed defect (fixed)

highway=road when tagged looks like boundary=administrative

Reported by: rickmastfan67 Owned by: team
Priority: major Milestone: 14.01
Component: Internal mappaint style Version: latest
Keywords: Cc:

Description (last modified by mrwojo)

highway=road (even as a temporary tag till somebody tags it correctly) shouldn't be shown in the same way as an Administrative boundary. People wouldn't know to double check it because of that. It should be shown in a different way.

Maybe show it as a normal road with a red outline? Kinda like how the "tiger:reviewed=no" is done except use red instead of yellow.

Attachments (1)

6039.patch (578 bytes) - added by simon04 8 years ago.
non-working patch

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by simon04

Attachment: 6039.patch added

non-working patch

comment:1 Changed 8 years ago by simon04

The attached patch (attachment:6039.patch) does not work as expected. Where is the problem?

comment:2 Changed 7 years ago by mrwojo

Description: modified (diff)

source:/josm/trunk/src/org/openstreetmap/josm/gui/mappaint/xml/XmlStyleSource.java#L238

There's a comment there: "do not use overlay if linestyle is from the same rule (example: railway=tram)". Thus if a line and a linemod are specified in the same rule, the linemod will apply only if the line style is not applied.

I think the conditional application of linemod should be explicit in the rule somehow.

comment:3 Changed 6 years ago by Don-vip

Milestone: 14.01

See #7746 comments for fix.

comment:4 Changed 6 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 6709/josm:

fix #6039, fix #7746:

  • highway=road when tagged looked like boundary=administrative
  • wrong style applied to ways for deprecated tags

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.