Modify

Opened 11 years ago

Last modified 3 months ago

#5846 new defect

AssertionError when undoing PurgeCommand

Reported by: Upliner Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: purge undo command stack Cc: skyper

Description (last modified by Don-vip)

Steps to reproduce:

  • Download some data
  • Purge it without clearing undoredo
  • Download the data again
  • Undo the PurgeCommand

java.lang.AssertionError: Primitive {Node id=338367679 version=4 V lat=51.4074839,lon=31.2550692} was removed when purging, but is still there on undo

at org.openstreetmap.josm.command.PurgeCommand.undoCommand(PurgeCommand.java:137)

Attachments (0)

Change History (12)

comment:1 Changed 11 years ago by Upliner

Description: modified (diff)
Summary: AssertionException when undoing PurgeCommandAssertionError when undoing PurgeCommand

comment:2 Changed 11 years ago by bastiK

I'd say the problem is not with the purge command, but the fact that "download data" does not show up in the command list.

comment:3 Changed 9 years ago by Don-vip

Ticket #7706 has been marked as a duplicate of this ticket.

comment:4 Changed 9 years ago by Don-vip

Cc: skyper added
Description: modified (diff)

comment:5 Changed 9 years ago by Don-vip

It's also possible to get the data again by merging layers (see #7706). Why not simply remove this assertion ?

comment:6 Changed 9 years ago by bastiK

You can edit, purge and redownload an object. If you want to restore the modified object on undo, it gets slightly more complicated.

comment:7 Changed 7 years ago by skyper

Ticket #8898 has been marked as a duplicate of this ticket.

comment:8 Changed 7 years ago by skyper

See #7489 for the work in progress.

comment:9 Changed 4 years ago by Don-vip

Keywords: purge added

comment:10 Changed 2 years ago by Don-vip

Keywords: undo added

comment:11 in reply to:  5 Changed 3 months ago by skyper

See also #11333 and #19331.

Replying to bastiK:

I'd say the problem is not with the purge command, but the fact that "download data" does not show up in the command list.

See #7489 for this approach but I am not sure if it is really needed or useful.

Replying to Don-vip:

It's also possible to get the data again by merging layers (see #7706). Why not simply remove this assertion ?

Is creating an object version conflict the way to go?

comment:12 Changed 3 months ago by skyper

Keywords: command stack added

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to Upliner
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.