Modify

Opened 11 years ago

Closed 11 years ago

#5843 closed enhancement (fixed)

[PATCH] Add Tags with remotcontrol plugin

Reported by: freemaps.osm@… Owned by: Christoph Wagner
Priority: normal Milestone:
Component: Core Version: tested
Keywords: remotecontrol Cc:

Description

In the attachment there is a patch for the josm remote control plugin.

If you call the load_and_zoom request you can now give a addtags parameter, so you can add the given tags directly with josm.

It is usefull for example to set wikipedia tags to osm objects over a generated HTML list.

Try this one for example:
http://localhost:8111/load_and_zoom?addtags=wikipedia:de=Wei%C3%9Fe_Gasse|maxspeed=5&select=way23071688,way23076176,way23076177,&left=13.739727546842&right=13.740890970188&top=51.049987191025&bottom=51.048466954325

The key and value is separated by "=" and multiple tags can be separated by a Pipe "|".

The user can review the tags and the selection before the tags are applied to the selected objects.

Would be nice if someone could add this patch to the core application.
Thanks Christoph

Attachments (2)

remotecontrol.patch (3.3 KB) - added by freemaps.osm@… 11 years ago.
Patch for the remotecontrol to add tags
remotecontrol_addtags.patch (19.5 KB) - added by freemaps.osm@… 11 years ago.
new patch witch bugs fixed and some mor features

Download all attachments as: .zip

Change History (8)

Changed 11 years ago by freemaps.osm@…

Attachment: remotecontrol.patch added

Patch for the remotecontrol to add tags

comment:1 Changed 11 years ago by bastiK

Summary: Add Tags with remotcontrol plugin[PATCH] Add Tags with remotcontrol plugin

comment:2 Changed 11 years ago by Kolossos

The server-side application to add wikipedia-tags and translations to OSM is now ready:

http://toolserver.org/~kolossos/osm-add-tags/index.php?lang=en&bbox=-0.35%2C51.385%2C0.05%2C51.585&cat=Streets_in_London&key=highway&value=*&basedeep=2&types=lines&request=Submit&iwl=yes

So it would be nice to review the patch to can go the next steps (testing, testing, publishing). Thanks Kolossos

comment:4 Changed 11 years ago by anonymous

ok, we fixed all that split stuff and added some extra features.
Now you can select the tags you wish to add.
Tags that exist in the current selection are greyed and not selected by default.

Please have a look if it is ok now.

Thanks
Christoph

PS: I don't know why this autoformatting stuff in eclipse creates so many changed lines in that patch.

Changed 11 years ago by freemaps.osm@…

Attachment: remotecontrol_addtags.patch added

new patch witch bugs fixed and some mor features

comment:5 Changed 11 years ago by Kolossos

We build in also the ideas from Bodo:

We deselect everything at beginning so that we get no problem if the user use addtags without select-parameter.

The other little wish was to give the dialog a good title. We fulfil this too.

Thanks and Greetings Kolossos

comment:6 Changed 11 years ago by bastiK

Resolution: fixed
Status: newclosed

In [3850/josm]:

applied #5843 (patch by Christoph and Kolossos) - Add Tags with remotcontrol plugin

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christoph Wagner.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.