Opened 14 years ago
Closed 14 years ago
#5843 closed enhancement (fixed)
[PATCH] Add Tags with remotcontrol plugin
Reported by: | Owned by: | Christoph Wagner | |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core | Version: | tested |
Keywords: | remotecontrol | Cc: |
Description
In the attachment there is a patch for the josm remote control plugin.
If you call the load_and_zoom request you can now give a addtags parameter, so you can add the given tags directly with josm.
It is usefull for example to set wikipedia tags to osm objects over a generated HTML list.
Try this one for example:
http://localhost:8111/load_and_zoom?addtags=wikipedia:de=Wei%C3%9Fe_Gasse|maxspeed=5&select=way23071688,way23076176,way23076177,&left=13.739727546842&right=13.740890970188&top=51.049987191025&bottom=51.048466954325
The key and value is separated by "=" and multiple tags can be separated by a Pipe "|".
The user can review the tags and the selection before the tags are applied to the selected objects.
Would be nice if someone could add this patch to the core application.
Thanks Christoph
Attachments (2)
Change History (8)
by , 14 years ago
Attachment: | remotecontrol.patch added |
---|
comment:1 by , 14 years ago
Summary: | Add Tags with remotcontrol plugin → [PATCH] Add Tags with remotcontrol plugin |
---|
comment:2 by , 14 years ago
The server-side application to add wikipedia-tags and translations to OSM is now ready:
So it would be nice to review the patch to can go the next steps (testing, testing, publishing). Thanks Kolossos
comment:3 by , 14 years ago
The urls from your website do not work: http://localhost:8111/load_and_zoom?addtags=wikipedia:en%3DCheapside|&select=way49775884,way3998353,way4268675,way3709267,&left=-0.09718447120216&right=-0.09080172871482&top=51.514929266044&bottom=51.513215098327
It tries to split by "=" but wikipedia:en%3DCheapside
has still %3D in it.
comment:4 by , 14 years ago
ok, we fixed all that split stuff and added some extra features.
Now you can select the tags you wish to add.
Tags that exist in the current selection are greyed and not selected by default.
Please have a look if it is ok now.
Thanks
Christoph
PS: I don't know why this autoformatting stuff in eclipse creates so many changed lines in that patch.
by , 14 years ago
Attachment: | remotecontrol_addtags.patch added |
---|
new patch witch bugs fixed and some mor features
comment:5 by , 14 years ago
We build in also the ideas from Bodo:
We deselect everything at beginning so that we get no problem if the user use addtags without select-parameter.
The other little wish was to give the dialog a good title. We fulfil this too.
Thanks and Greetings Kolossos
Patch for the remotecontrol to add tags