Modify

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#570 closed defect (fixed)

voice tag are recognized as simple markers

Reported by: dodi@… Owned by: framm
Priority: major Milestone:
Component: Core Version: latest
Keywords: voice tag Cc:

Description

<wpt lat="54.47613000" lon="9.78714500">

<ele>47.50000000</ele>
<name>Beginn des Trampelpfads</name>
<time>2007-11-11T11:25.06Z</time>
<link href="voice.wav"/>

</wpt>

is recognized as voice tag but

<wpt lat="54.47613000" lon="9.78714500">

<ele>47.50000000</ele>
<name>Beginn des Trampelpfads</name>
<time>2007-11-11T11:25.06Z</time>
<link>voice.wav</link>

</wpt>

is recognized as simple marker (this form of link is generate by OSMtracker and in JOSM versions prior 455 worked well as voice tag)

Attachments (0)

Change History (6)

comment:1 Changed 11 years ago by Gabriel Ebner <ge@…>

Resolution: wontfix
Status: newclosed

<link>URL</link> is not valid GPX: http://www.topografix.com/GPX/1/1/#type_linkType

comment:2 Changed 11 years ago by anonymous

Resolution: wontfix
Status: closedreopened

This feature WAS supported (e.g. in josm-latest.jar from 19.10.2007).
Such gpx files are produced by OSMtracker (http://wiki.openstreetmap.org/index.php/OSMtracker)...

And you can find it at http://www.topografix.com/GPX/1/1/gpx.xsd (if I understood it correctly).

comment:3 Changed 11 years ago by Gabriel Ebner <ge@…>

Yes, I know that this was supported, and that such files are produced by osmtracker. And yes, I have read the schema, and it clearly shows that <link>URL</link> is NOT VALID according to the schema.

To be exact, the schema requires a href attribute on <link>, and doesn't allow any text inside <link>.

It would be a one-liner to support this invalid syntax. And I'd already have comitted it if it were produced by a widespread software, say OziExplorer, which we could never hope to fix because we're too unimportant.

But this is osmtracker, and I assume this particular feature was even geared towards JOSM. I see no reason why we should implement such point-less workarounds. If it were open source, its author would already have a patch in his inbox.

Just for the record, this is probably all that's needed to implement this workaround:

Index: src/org/openstreetmap/josm/io/GpxReader.java
===================================================================
--- src/org/openstreetmap/josm/io/GpxReader.java        (revision 507)
+++ src/org/openstreetmap/josm/io/GpxReader.java        (working copy)
@@ -197,6 +197,10 @@
                                } else if (qName.equals("type")) {
                                        currentLink.type = accumulator.toString();
                                } else if (qName.equals("link")) {
+                                       // <link>URL</link>
+                                       if (currentLink.uri == null)
+                                               currentLink.uri = accumulator.toString();
+
                                        currentState = states.pop();
                                }
                                if (currentState == state.author) {

comment:4 Changed 11 years ago by dodi@…

Will ask Rubke the author of OSMtracker to fix this one, but if the iz change not so complicated it would be nice to have this small workaround atleast until we get <link> tag fixed in OSMtracker and for logs already made by OSMtracker.

Thanx. Dodi

comment:5 Changed 11 years ago by Gabriel Ebner <ge@…>

Resolution: fixed
Status: reopenedclosed

Fixed in r512.

comment:6 Changed 11 years ago by anonymous

fixed in OSMtracker 0.3.8, so only gpx-files created with some old version are affected.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain framm.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.