Modify ↓

Opened 15 years ago

Closed 8 years ago

#5676 closed defect (fixed)

edit summary (changeset comment) in upload dialog sometimes still uses old value

Reported by: stw1701 Owned by: michael2402
Priority: critical Milestone: 17.05
Component: Core Version: tested
Keywords: upload dialog changeset comment Cc: jinalfoflia, Thib, dido

Description (last modified by Don-vip)

When entering a new text in the "brief comment" field in the upload dialogue, sometimes the old value is still used and sent to the server.

This is hard to reproduce even for me, but I think it has something to do with the way Java registers changes in the checkbox. I'd have to press Return two or three times to get it right. Interesting thing is that the new value still shows up when I open the dialogue again.

Version 3592

Attachments (0)

Change History (8)

in reply to:  description comment:1 by stw1701, 15 years ago

Alright, just tried various methods of entering text in that field. To reproduce follow these steps:

  1. change something
  2. press upload
  3. enter some new text, overwriting an old value, don't press Return!
  4. click on the "Upload Changes" button

Results:

  • changes are upload to the server
  • change comment is set to the old value
  • next time the upload dialogue is opened, the new value is shown

Expected results:

  • changes are upload
  • change comment is set to the new value

comment:2 by Don-vip, 9 years ago

Description: modified (diff)
Keywords: dialog changeset comment added; dialogue removed
Priority: minor → critical
Summary: edit summary in upload dialogue sometimes still uses old value → edit summary (changeset comment) in upload dialog sometimes still uses old value

comment:3 by Don-vip, 9 years ago

Ticket #13270 has been marked as a duplicate of this ticket.

comment:4 by Don-vip, 9 years ago

Ticket #14233 has been marked as a duplicate of this ticket.

comment:5 by Don-vip, 9 years ago

Ticket #14316 has been marked as a duplicate of this ticket.

comment:6 by Don-vip, 9 years ago

Cc: jinalfoflia Thib dido added

comment:7 by michael2402, 9 years ago

Milestone: → 17.05
Owner: changed from team to michael2402
Status: new → assigned

comment:8 by michael2402, 8 years ago

Resolution: → fixed
Status: assigned → closed

In 12265/josm:

Fix #5676: Force a reload of the edit summary field if the user uploads data.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain michael2402.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.