Modify ↓

Opened 14 years ago

Closed 10 years ago

#5264 closed defect (fixed)

error occurs when closing josm

Reported by: jongleur1983@… Owned by: jttt
Priority: normal Milestone:
Component: Core Version: latest
Keywords: template_report Cc:

Description (last modified by Don-vip)

What steps will reproduce the problem?
(reproduction untested)

  1. copy a data layer containing data (e.g. fresh downloaded from osm)
  2. exit josm without saving or updating

What is the expected result?
JOSM should exit without saving quietly, I think.

What happens instead?
Instead an error dialog box appears, asking for reporting the bug. After closing the box (no matter, what choice I used), one data layer is gone, but josm is not closed. I can repeat closing getting the same behaviour.

Please provide any additional information below. Attach a screenshot if
possible.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2010-07-22 01:31:57
Last Changed Author: stoecker
Revision: 3380
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2010-07-21 21:17:09 +0200 (Wed, 21 Jul 2010)
Last Changed Rev: 3380

Identification: JOSM/1.5 (3380 de)
Memory Usage: 72 MB / 483 MB (34 MB allocated, but free)
Java version: 1.6.0_18, Sun Microsystems Inc., OpenJDK Server VM
Operating system: Linux

Plugin: PicLayer (21706)
Plugin: measurement (21706)
Plugin: openstreetbugs (21706)
Plugin: osmarender (21774)
Plugin: turnrestrictions (21706)
Plugin: validator (22204)
Plugin: walkingpapers (21706)

java.lang.NullPointerException
	at org.openstreetmap.josm.data.AutosaveTask.setLayerFileName(AutosaveTask.java:113)
	at org.openstreetmap.josm.data.AutosaveTask.savelayer(AutosaveTask.java:149)
	at org.openstreetmap.josm.data.AutosaveTask.layerRemoved(AutosaveTask.java:216)
	at org.openstreetmap.josm.gui.MapView.fireLayerRemoved(MapView.java:148)
	at org.openstreetmap.josm.gui.MapView.removeLayer(MapView.java:360)
	at org.openstreetmap.josm.Main.exitJosm(Main.java:517)
	at org.openstreetmap.josm.gui.MainApplication$1.windowClosing(MainApplication.java:63)
	at java.awt.AWTEventMulticaster.windowClosing(AWTEventMulticaster.java:349)
	at java.awt.AWTEventMulticaster.windowClosing(AWTEventMulticaster.java:349)
	at java.awt.AWTEventMulticaster.windowClosing(AWTEventMulticaster.java:349)
	at java.awt.Window.processWindowEvent(Window.java:1865)
	at javax.swing.JFrame.processWindowEvent(JFrame.java:290)
	at java.awt.Window.processEvent(Window.java:1823)
	at java.awt.Component.dispatchEventImpl(Component.java:4469)
	at java.awt.Container.dispatchEventImpl(Container.java:2163)
	at java.awt.Window.dispatchEventImpl(Window.java:2478)
	at java.awt.Component.dispatchEvent(Component.java:4295)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:604)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:275)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:200)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:190)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:185)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:177)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:138)

Attachments (0)

Change History (10)

comment:1 by anonymous, 14 years ago

Version: → latest

comment:2 by anonymous, 14 years ago

Owner: changed from team to jttt

comment:3 by jttt, 14 years ago

Resolution: → fixed
Status: new → closed

(In [3381]) Fix #5264 error occurs when closing josm

comment:4 by skyper, 14 years ago

Resolution: fixed
Status: closed → reopened

There is still a problem:

Trying to delete a layer which was uploaded and without any new changes. I get still asked to upload it.

comment:5 by jttt, 14 years ago

If you confirm the upload, is upload dialog shown or only the message "No changes to upload"?

comment:6 by skyper, 14 years ago

Resolution: → worksforme
Status: reopened → closed

Can not reproduce it with r3399 anymore.

I close the ticket and reopen it if needed (reproducable)

comment:7 by anonymous, 14 years ago

Resolution: worksforme → fixed

comment:8 by skyper, 14 years ago

Resolution: fixed
Status: closed → reopened

It happened again with r3399.

There are only one data and the validator layer open. I have uploaded successfully after 2 conflicts been solved and all objects have been updated. I wanted to exit JOSM and got the upload/save dialog.

If I press "upload/save and exit" JOSM opens the upload-dialog and wants to upload zero objects.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2010-08-01 01:31:29
Last Changed Author: framm
Revision: 3399
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2010-07-31 21:22:49 +0200 (Sat, 31 Jul 2010)
Last Changed Rev: 3399

Identification: JOSM/1.5 (3399 en)
Memory Usage: 180 MB / 248 MB (17 MB allocated, but free)
Java version: 1.6.0_0, Sun Microsystems Inc., OpenJDK Client VM
Operating system: Linux
Dataset consistency test: No problems found

Plugin: ColumbusCSV (305)
Plugin: RoadSigns (22449)
Plugin: openstreetbugs (22466)
Plugin: public_transport (22048)
Plugin: remotecontrol (22479)
Plugin: validator (22457)
Plugin: wmsplugin (22286)

cache.motd.html=1280710440
cache.motd.html.version=3399
cache.wmsplugin.expire=2419200
cache.wmsplugin.maxsize=70
columbuscsv.import.showSummary=false
commandstack.minimized=true
conflictresolutiondialog.height=578
conflictresolutiondialog.width=725
conflictresolutiondialog.y=25
coordinates=DECIMAL_DEGREES
download.newlayer=true
downloadprimitive.lasttype=2
downloadprimitive.referrers=true
draw.segment.order_number=true
filter.minimized=true
filters.filter.0=1;type:node;replace;false;false;legacy;false;true;false;false
filters.filter.1=1;boundary;add;false;false;legacy;false;true;false;false
filters.filter.2=1;lcn;replace;false;false;legacy;false;true;true;false
gui.geometry=779x528+116+86
gui.maximized=true
josm.version=3399
laf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel
language=en
lastDirectory=/home/gast/Desktop
marker.audiofromstart=false
message.movedManyElements.value=1
mirror.http://svn.openstreetmap.org/applications/editors/josm/plugins/validator/ignoretags.cfg=1280184320300;/home/gast/.josm-latest/plugins/validator/mirror_http___svn.openstreetmap.org_applications_editors_josm_plugins_validator_ignoretags.cfg
mirror.http://svn.openstreetmap.org/applications/editors/josm/plugins/validator/tagchecker.cfg=1280184320437;/home/gast/.josm-latest/plugins/validator/mirror_http___svn.openstreetmap.org_applications_editors_josm_plugins_validator_tagchecker.cfg
mirror.http://svn.openstreetmap.org/applications/editors/josm/plugins/wmsplugin/sources.cfg=1280187569706;/home/gast/.josm-latest/plugins/wmsplugin/mirror_http___svn.openstreetmap.org_applications_editors_josm_plugins_wmsplugin_sources.cfg
mirror.http://svn.openstreetmap.org/applications/utils/planet.osm/java/speller/words.cfg=1280184320113;/home/gast/.josm-latest/plugins/validator/mirror_http___svn.openstreetmap.org_applications_utils_planet.osm_java_speller_words.cfg
org.openstreetmap.josm.gui.actionsupport.DeleteFromRelationConfirmationDialog.geometry=x=312,y=285,width=400,height=200
org.openstreetmap.josm.gui.conflict.tags.CombinePrimitiveResolverDialog.geometry=x=212,y=185,width=600,height=400
org.openstreetmap.josm.gui.dialogs.relation.GenericRelationEditor.geometry=x=290,y=60,width=700,height=643
org.openstreetmap.josm.gui.download.DownloadDialog.geometry=x=12,y=85,width=1000,height=600
org.openstreetmap.josm.gui.io.UploadDialog.geometry=x=312,y=31,width=558,height=712
org.openstreetmap.josm.gui.oauth.OAuthAuthorizationWizard.geometry=x=287,y=115,width=450,height=540
org.openstreetmap.josm.gui.preferences.PreferenceDialog.geometry=x=212,y=25,width=600,height=718
osb.api.disabled=false
osb.auto_download=true
osb.include_date=true
osb.uri.close=http://openstreetbugs.schokokeks.org/api/0.1/closePOIexec
osb.uri.download=http://openstreetbugs.schokokeks.org/api/0.1/getBugs
osb.uri.edit=http://openstreetbugs.schokokeks.org/api/0.1/editPOIexec
osb.uri.new=http://openstreetbugs.schokokeks.org/api/0.1/addPOIexec
osm-download.bounds=48.0218358;7.863689699999999;48.023988599999996;7.8715432
osm-primitives.showid=true
osm-server.auth-method=oauth
osm-server.upload-strategy=chunked
osm-server.upload-strategy.chunk-size=20
pluginmanager.lastupdate=1280710439165
pluginmanager.time-based-update.interval=1
pluginmanager.time-based-update.policy=always
pluginmanager.version=3399
pluginmanager.version-based-update.policy=always
plugins=ColumbusCSV
RoadSigns
openstreetbugs
public_transport
remotecontrol
validator
wmsplugin
proxy.policy=no-proxy
relation.editor.generic.lastrole=outer
relationlist.visible=true
search.history=R "Mo-Fr 10.00-19.00"
R "Mo-Fr 10:00-19.00"
R 0761/
R holiday
R ref="B 312;B 313"
S ref="B 312;B 313"
S ref="B 312"
S ref="B 28"
D ref="B 313"
D ref=B 313
shortcut.groups.1=128
shortcut.groups.10=64
shortcut.groups.11=576
shortcut.groups.12=64
shortcut.groups.13=512
shortcut.groups.15=640
shortcut.groups.16=640
shortcut.groups.17=576
shortcut.groups.18=512
shortcut.groups.19=128
shortcut.groups.2=128
shortcut.groups.20=512
shortcut.groups.3=0
shortcut.groups.4=512
shortcut.groups.5=0
shortcut.groups.6=512
shortcut.groups.8=192
shortcut.groups.9=192
shortcut.groups.configured=true
toolbar=open
save
download
upload
|
undo
redo
|
dialogs/search(searchExpression=)
preference
|
splitway
combineway
wayflip
|
tagginggroup_Highways/Streets
tagginggroup_Highways/Ways
tagginggroup_Highways/Waypoints
tagginggroup_Highways/Barriers
|
tagginggroup_Transport/Car
tagginggroup_Transport/Public Transport
|
tagginggroup_Travel/Tourism
tagginggroup_Travel/Food+Drinks
|
tagginggroup_Travel/Historic Places
|
tagginggroup_Man-Made/Man Made
undelete.newlayer=true
undelete.osmid=31495
upload.comment.history=PLZ 79104
FR Metzgerei Sumser
FR Zähringen/Wildtal landuse
FR Herdern adressen
FR Rennweg
FR st otilien
PLZ 79098 fixes Schlossberg
PLZ 79098 fixes
FR Schwarzwald-City
FR My Kim
Riquewihr
FR Bahngelände
FR kronenstr 
Fr adressen
Fr nächliche Geschwindigkeitsbeschränkung
upload.comment.last-used=1280735179
validator.tests=Coastlines=true,MultipolygonTest=true,SimilarNamedWays=true,UntaggedNode=true,RelationChecker=true,CrossingWays=true,NodesWithSameName=true,TagChecker=true,OverlappingWays=true,UnclosedWays=true,WronglyOrderedWays=true,UnconnectedWays=true,SelfIntersectingWay=true,DuplicatedWayNodes=true,NameMismatch=true,DuplicateWay=true,UntaggedWay=true,TurnrestrictionTest=true,DuplicateNode=true
validator.testsBeforeUpload=Coastlines=true,MultipolygonTest=true,SimilarNamedWays=true,UntaggedNode=true,RelationChecker=true,CrossingWays=true,NodesWithSameName=true,TagChecker=true,OverlappingWays=true,UnclosedWays=true,WronglyOrderedWays=true,UnconnectedWays=true,SelfIntersectingWay=true,DuplicatedWayNodes=true,NameMismatch=true,DuplicateWay=true,UntaggedWay=true,TurnrestrictionTest=true,DuplicateNode=true
wmsplugin.default.html:http://josm.openstreetmap.de/wmsplugin/YahooDirect.html?=true
wmsplugin.default.http://onearth.jpl.nasa.gov/wms.cgi?request_GetMap&layers_global_mosaic&styles_&format_image/jpeg&=true
wmsplugin.simultaneousConnections=3
wmsplugin.url.0.name=Landsat
wmsplugin.url.0.url=http://onearth.jpl.nasa.gov/wms.cgi?request=GetMap&layers=global_mosaic&styles=&format=image/jpeg&
wmsplugin.url.1.name=PLZ
wmsplugin.url.1.url=http://tools.geofabrik.de/osmi/view/plz/wxs?REQUEST=GetMap&SERVICE=wms&VERSION=1.1.1&FORMAT=image/png&SRS=EPSG:4326&STYLES=&LAYERS=plz_source,plz_osm&
wmsplugin.url.2.name=Yahoo Sat
wmsplugin.url.2.url=html:http://josm.openstreetmap.de/wmsplugin/YahooDirect.html?
wmsplugin.url.3.name=pristina
wmsplugin.url.3.url=http://staging.mapwarper.net/maps/wms/2392?request=GetMap&version=1.1.1&styles=&format=image/png&srs=epsg:4326&exceptions=application/vnd.ogc.se_inimage&
wmsplugin.url.overlap=false
wmsplugin.url.overlapEast=14
wmsplugin.url.overlapNorth=4

Maybe it is important: my machine is swapping quite a lot right now.

comment:9 by Don-vip, 10 years ago

Description: modified (diff)

This ticket is about the NPE and it has been fixed correctly in r3381. For the save/upload problem, please see #6184.

comment:10 by Don-vip, 10 years ago

Resolution: → fixed
Status: reopened → closed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain jttt.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.