Opened 15 years ago
Closed 13 years ago
#5218 closed defect (fixed)
Validator does not know many relation-types
Reported by: | skyper | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core validator | Version: | latest |
Keywords: | unknown relation type | Cc: |
Description (last modified by )
Validator does not know type=site, associatedStreet, TMC, bridge and other either common used or approved relations-types. Instead you get a warning about an unknown relation-type.
r3362 , o22065
cu skyper
Attachments (0)
Change History (17)
follow-up: 2 comment:1 by , 15 years ago
comment:2 by , 15 years ago
Replying to stoecker:
Actually JOSM startup page already tells you about that fact. You can help by providing new entries or the relation presets menu.
The way the presets work in JOSM right now, I rather clone an existing relation or manually create the relation, which is much faster than using presets.
comment:3 by , 15 years ago
I also get a warning from the validator for type=waterway, altough this entry is recognized in the relation view and translated to "Gewässer".
How exactly can I provide new entries for the relation presets menu?
comment:4 by , 15 years ago
See data/defaultpresets.xml. At the beginning is the description, ad the end the relations. Basically you need to specify a block which contains the tags and one with the roles of a relation:
Example for multipolygon:
<item name="Multipolygon" icon="presets/empty.png" type="relation"> <link href="http://wiki.openstreetmap.org/wiki/Relation:multipolygon" de.href="http://wiki.openstreetmap.org/wiki/DE:Relation:multipolygon" fr.href="http://wiki.openstreetmap.org/wiki/FR:Relation:multipolygon" /> <label text="Edit Multipolygon" /> <key key="type" value="multipolygon" /> <optional> <text key="name" text="Name" default="" delete_if_empty="true" /> </optional> <roles> <role key="outer" text="outer segment" requisite="required" type="way" /> <role key="inner" text="inner segment" requisite="optional" type="way" /> </roles> </item>
BTW: What a type of relation should "type=waterway" be?
comment:5 by , 15 years ago
Thanks. The waterway relation type is for rivers, canals:
http://wiki.openstreetmap.org/wiki/Relations/Proposed/Waterway
Though still a proposal it is already used for many rivers:
http://wiki.openstreetmap.org/wiki/WikiProject_Germany/Gew%C3%A4sser
comment:6 by , 14 years ago
Ticket #6080 (Relation type Enforcement is unknown but it's official) has been marked as a duplicate of this ticket.
comment:7 by , 13 years ago
Ticket #7044 (Do not warn about relations with role=house as member of associatedStreet) has been marked as a duplicate of this ticket.
comment:8 by , 13 years ago
Description: | modified (diff) |
---|
type=network
and type=associatedStreet
have been added in r3544.
comment:10 by , 13 years ago
IMHO, TMC cannot be handled by a preset in JOSM as it requires varying keys (e.g. TMC:cid_
58
:tabcd_1:LocationCode=1234
).
follow-up: 16 comment:12 by , 13 years ago
If I see it correctly, from the frequent used relation types, there are (only) a few from the Oxomoa scheme missing (stop_area
, stop_area_group
, line
, …).
comment:14 by , 13 years ago
These checkins should have waited until after release. Now the translations are incomplete again.
comment:15 by , 13 years ago
Sorry … However, now the presets are more complete and the validator less falsely verbose. :-)
follow-up: 17 comment:16 by , 13 years ago
Replying to simon04:
If I see it correctly, from the frequent used relation types, there are (only) a few from the Oxomoa scheme missing (
stop_area
,stop_area_group
,line
, …).
I was more concerned about common relations not about Oxomoa speciales.
I thought there is a plugin for this scheme.
Does Validator include values from plugins ?
Anyway, I think we can close this ticket and either reopen it or open a new ticket if it is needed.
Thanks.
comment:17 by , 13 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Replying to skyper:
Does Validator include values from plugins ?
As far as I know, the validator makes use of any active presets.
Actually JOSM startup page already tells you about that fact. You can help by providing new entries or the relation presets menu.