Modify

Opened 9 years ago

Closed 21 months ago

Last modified 21 months ago

#5144 closed defect (fixed)

[Patch] Cannot add new paths when filter is active

Reported by: extropy Owned by: michael2402
Priority: normal Milestone: 17.04
Component: Core Version: tested
Keywords: filter Cc:

Description (last modified by skyper)

Found on JOSM version 3329

Steps to reproduce:

  • Download some data from OSM, containing roads.
  • Create a filter "highway=*" and make it inverse (rightmost checkbox).
  • Now the map shows roads in color and everything else grayed out.
  • Start drawing a new line.
  • Only points are drawn, no line and selection is empty.

Expected behavior:

  • A line is drawn and is selected.
  • You can add tags to the drawn line.
  • After it is deselected, it behaves like all other lines.

Attachments (1)

fix-5144.patch (6.0 KB) - added by michael2402 2 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 7 years ago by skyper

Description: modified (diff)

reproduced with r4707

Changed 2 years ago by michael2402

Attachment: fix-5144.patch added

comment:2 Changed 2 years ago by michael2402

Summary: Cannot add new paths when filter is active[Patch] Cannot add new paths when filter is active

The patch changes the behavior to expected.

You can add tags to the way after creating it and the filter will be applied as soon as you exit draw mode or as soon as you start drawing the next way.

comment:3 Changed 2 years ago by andygol

To be able to draw a new line when filter active, just modify filtering pattern as
--> "highway=*" | new

comment:4 Changed 23 months ago by Don-vip

Keywords: filter added
Milestone: 17.03
Priority: majornormal

comment:5 Changed 23 months ago by Don-vip

The patch does not apply anymore, but I agree with the modification, you can commit it Michael :)

comment:6 Changed 22 months ago by michael2402

Owner: changed from team to michael2402

comment:7 Changed 22 months ago by Don-vip

Milestone: 17.0317.04

comment:8 Changed 21 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 11993/josm:

fix #5144 - Cannot draw new ways when filter is active (patch by michael2402)

comment:9 Changed 21 months ago by Don-vip

In 11997/josm:

see #5144 - fix NPE

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain michael2402.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.