Modify

Opened 14 years ago

Closed 7 years ago

Last modified 5 years ago

#5144 closed defect (fixed)

[Patch] Cannot add new paths when filter is active

Reported by: extropy Owned by: michael2402
Priority: normal Milestone: 17.04
Component: Core Version: tested
Keywords: filter Cc:

Description (last modified by skyper)

Found on JOSM version 3329

Steps to reproduce:

  • Download some data from OSM, containing roads.
  • Create a filter "highway=*" and make it inverse (rightmost checkbox).
  • Now the map shows roads in color and everything else grayed out.
  • Start drawing a new line.
  • Only points are drawn, no line and selection is empty.

Expected behavior:

  • A line is drawn and is selected.
  • You can add tags to the drawn line.
  • After it is deselected, it behaves like all other lines.

Attachments (1)

fix-5144.patch (6.0 KB ) - added by michael2402 7 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 by skyper, 12 years ago

Description: modified (diff)

reproduced with r4707

by michael2402, 7 years ago

Attachment: fix-5144.patch added

comment:2 by michael2402, 7 years ago

Summary: Cannot add new paths when filter is active[Patch] Cannot add new paths when filter is active

The patch changes the behavior to expected.

You can add tags to the way after creating it and the filter will be applied as soon as you exit draw mode or as soon as you start drawing the next way.

comment:3 by andygol, 7 years ago

To be able to draw a new line when filter active, just modify filtering pattern as
--> "highway=*" | new

Last edited 5 years ago by andygol (previous) (diff)

comment:4 by Don-vip, 7 years ago

Keywords: filter added
Milestone: 17.03
Priority: majornormal

comment:5 by Don-vip, 7 years ago

The patch does not apply anymore, but I agree with the modification, you can commit it Michael :)

comment:6 by michael2402, 7 years ago

Owner: changed from team to michael2402

comment:7 by Don-vip, 7 years ago

Milestone: 17.0317.04

comment:8 by Don-vip, 7 years ago

Resolution: fixed
Status: newclosed

In 11993/josm:

fix #5144 - Cannot draw new ways when filter is active (patch by michael2402)

comment:9 by Don-vip, 7 years ago

In 11997/josm:

see #5144 - fix NPE

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain michael2402.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.