Opened 14 years ago
Closed 11 years ago
#5120 closed defect (fixed)
moving tags from outer way to MP-relation
Reported by: | brogo | Owned by: | bilbo |
---|---|---|---|
Priority: | major | Milestone: | |
Component: | Core multipoly | Version: | |
Keywords: | Cc: |
Description
When you create an multipolygon (e.g. a lake with an island), the tags (e.g. natural=water) belong to the relation, not to the outer way. If the outer way has tags, these should be moved to the new MP-relation.
Attachments (0)
Change History (19)
comment:1 by , 14 years ago
comment:2 by , 14 years ago
We could set "always" as default. This is what the wiki says for some time now. (Since Frederik Ramm put it there...)
Basically it is the task of the editor to make area (multipolygon) handling easier.
comment:3 by , 14 years ago
Well, the feature is not yet complete, but until #5592 is fixed, I don't think having "always" as default is a good idea.
comment:5 by , 13 years ago
Sooooooo?.. Can we have at least an option somewhere deep in settings list? :)
comment:7 by , 13 years ago
Link: http://wiki.openstreetmap.org/wiki/Multipolygon#Tagging
Note: You can edit tags of a relation in JOSM like for ways. You only need to select the relation (right click relation and select in popup in several places in josm).
comment:8 by , 13 years ago
Thanks for the link. Frederik Ramm put the mentioned suggestion on the page. Later he moved it to the discussion from where later Stoecker did move it back to the main page.
I do not agree (and don't see the sense) in tagging no outer way but put the tags into the relation as long as the tagged outer way is used in one multipolygon only.
This makes things IMO only more complicated and less obvious.
comment:9 by , 13 years ago
Well the relation is the object, so it should be tagged instead of the way. Nevertheless tagging outer ways will be supported also in the future.
follow-up: 11 comment:10 by , 13 years ago
So if there is a multipolygon contained in a multipolygon following you suggestions I should add the inner multipolygon but not the outer way of the inner multipolygon to the outer multipolygon as inner?
comment:11 by , 13 years ago
Replying to malenki:
So if there is a multipolygon contained in a multipolygon following you suggestions I should add the inner multipolygon but not the outer way of the inner multipolygon to the outer multipolygon as inner?
This is nonsense. We define areas by the boundary lines and not by a mixture of boundary line and adjacent areas. Also, it has nothing to do with putting the tags on the relation as the actual object that represents the area. In practice, it may be more convenient to tag the single outer way, but we shouldn't stop people who like to do it right.
comment:12 by , 13 years ago
Thanks for the "nonsense". I only continued stoecker's thought of using the object (the multipolygon) instead of some helping way.
follow-up: 14 comment:13 by , 13 years ago
It is plainly wrong. Not the area is the inner part, but the outer ring of this area. Which you can easily verify when you have a wood containing of 10 small parts scattered around. Then not this multipolygon-wood is the inner element of the whatevers laying around (e.g. multiple landuses like farms), but the individual outer rings.
You try to construct silly examples and mangle different topics to prove your point. As bastiK correctly says this is nonsense.
comment:14 by , 13 years ago
Replying to stoecker:
You try to construct silly examples and mangle different topics to prove your point. As bastiK correctly says this is nonsense.
Neither is my example "silly" (I have seen and created quite a lot multipolys contaning multipolys) nor did I want to prove something nor mangle different topics. I asked a question based on continuing your thoughts, so what? Maybe I am just too stupid to follow the hi-flying thoughts in here?
Anyway I thank you very much for the sensible, rational and friendly answers.
comment:15 by , 13 years ago
BTW, this functionality is now implemented in the reltoolbox plugin: http://wiki.openstreetmap.org/wiki/JOSM/Plugins/Relation_Toolbox
follow-up: 17 comment:16 by , 13 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
This has been fixed.
comment:17 by , 13 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Type: | enhancement → defect |
comment:19 by , 11 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Not necessarily - the tags can be both on the outer way(s) or in the relation.
Copying tags to relation is good only if there are multiple outer ways (as the information should be present only once in database), it is not very good for single way, as it is then harder to edit the tags in JOSM (you have to click on relation editor to see and edit the tags) - though it is technically correct :)
I guess I'll add this feature with setting to copy the tags: "never"/"always"/"only if multiple outer ways" (which would be the default)