Modify

Opened 12 years ago

Closed 10 years ago

Last modified 10 years ago

#5075 closed enhancement (fixed)

Autocompletion for role button in relation dialog

Reported by: stoecker Owned by: bastiK
Priority: normal Milestone:
Component: Core Version:
Keywords: Cc:

Description (last modified by simon04)

The role field in relation dialog should support autocomplete and the drop-down-box (prefilled with the roles from presets, which are currently not parsed).

Also the dialog should remember the last selection of closing the session. Usually the chance is high that one handles equal roles one after another (e.g. for multipolygons, routes, ...)

@bastiK: Can you do this? You did a lot of autocomplete changes lately.

Attachments (0)

Change History (8)

comment:1 Changed 12 years ago by stoecker

The autocmplete code is already there, don't know why it did not work.

See r3289 and [o21539] for parsing of preset role definitions and remembering value.

Remaining issue, the role field should be a autocompletion combobox instead of the text field it is now.

comment:2 Changed 12 years ago by bastiK

I think you need at least one applied role of that type in the current data set. There should be "silent" presets for this (and also some other common tags that are not in the presets).

comment:3 Changed 12 years ago by bastiK

Further enhancement:

Have higher priority for roles that fit the type of the relation. E.g. type=multipolygon -> role: outer,inner is suggested.

comment:4 Changed 12 years ago by stoecker

What do you mean with previous comment? The role presets have been added in my latest change. Currently not yet type dependent. It didn't want to change the autocomplete interface too much before I really understand it (it changed really a lot :-).

Role handling could be now be done like for tags. The RoleChecker in validator already has code how to find matching preset(s) for a given relation. This can be used to choose set of "wanted" roles.

Common tags not in the presets should be added in presets instead of doing workarounds.

comment:5 Changed 12 years ago by bastiK

OK, the roles should be parsed from the presets.

Common tags not in the presets should be added in presets instead of doing workarounds.

What about these: fixme, fixme=incomplete, note, loc_name, alt_name, de:amtlicher_gemeindeschluessel and TMC related stuff.

comment:6 Changed 10 years ago by simon04

Description: modified (diff)

I think auto completion is working nicely (besides suggesting forward when I in fact want forward_stop). Anything to be done?

comment:7 Changed 10 years ago by simon04

Resolution: fixed
Status: newclosed

comment:8 in reply to:  6 Changed 10 years ago by skyper

Replying to simon04:

I think auto completion is working nicely (besides suggesting forward when I in fact want forward_stop). Anything to be done?

Take the object's type into account could solve some of these cases where roles with similar names exist.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain bastiK.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.