Modify

Opened 7 years ago

Last modified 11 months ago

#4929 new defect

Filtered and disabled objects can be selected

Reported by: bundesrainer Owned by: team
Priority: minor Milestone:
Component: Core Version: tested
Keywords: filters function Cc: malenki, Cobra

Description

When using the filter function, filtered objects are grayed out and can not be selected by clicking. But when I mark an area (Click + Hold) the filtered objects are also selected.

Attachments (1)

filters.osm (1.0 KB) - added by openstreetmap.org-user-d1g 11 months ago.

Download all attachments as: .zip

Change History (16)

comment:1 Changed 7 years ago by stoecker

Priority: normalcritical

comment:2 Changed 7 years ago by bastiK

Why is it critical? The objects are selected and filtered. It's not nice but it doesn't cause data corruption or something like that.

Note that there are other ways to get this situation:

  • select something, then change the filter to include these objects


  • use selection history
  • undo, such that the properties of a selected change and a filter applies

comment:3 Changed 7 years ago by bastiK

(In [3198]) see #4929 - rectangle selection selects filtered objects.
(the other things mentioned in this ticket are not addressed)

comment:4 Changed 7 years ago by bastiK

(In [3199]) see #4929 - filtered objects can be selected: fixed the first and the third issue from my reply (select something, then change the filter to include these objects; undo, such that the properties of a selected change and a filter applies)

comment:5 Changed 7 years ago by bastiK

What shall we do for search? There should be a dialog box or a popup message to inform the user that more was found, but could not be selected because of active filters.

comment:6 Changed 7 years ago by bastiK

Summary: Filter function has a bug (disabled objects can be selected)Filtered and disabled objects can be selected

comment:7 Changed 7 years ago by stoecker

Priority: criticalmajor

Why set as critical: Because the biggest problem I have with filtering is the fact that users may destroy valid data. This also was the reason why the filter was disabled by default for so long. As you fixed major issues I change it to major.

About "use selection history": We can delete it when filters are applied or changed.

comment:8 in reply to:  7 Changed 7 years ago by bastiK

About "use selection history": We can delete it when filters are applied or changed.

This would certainly annoy some users, including me. Another solution would be to purge the chosen selection like it needs to be done for deleted objects (?) and change the text in the popup menu to include the number of currently filtered/disabled (if any).

comment:9 Changed 7 years ago by extropy

Cannot reproduce this on Version 3329.
Is this fixed?

comment:10 Changed 7 years ago by bastiK

Remaining issues:

(a) 'search' results in filtered objects being selected
(b) search history allows filtered objects to be selected
(c) command stack select tool allows the same

I'm no longer sure, these are real issues. With respect to #5144 we should treat selected and filtered objects as if they weren't filtered.

comment:11 Changed 7 years ago by stoecker

Good idea (but I see another bunch of possible bug reports). Let's try it and see what the result is.

comment:12 Changed 6 years ago by skyper

Ticket #7238 has been marked as a duplicate of this ticket.

comment:13 Changed 6 years ago by skyper

Cc: malenki Cobra added

comment:14 in reply to:  2 Changed 11 months ago by openstreetmap.org-user-d1g

Untested

Replying to bastiK:

(b) search history allows filtered objects to be selected

1. missing activation in command history

Replying to bastiK:

(c) command stack select tool allows the same

Yes, it is possible to select, otherwise filtered objects in command history using right click menu.

Either solution would be okay:

  • display "Unselectable now" message, suppress right click menu
  • display object, add "currently filtered out" in node/way/relation caption, disable respective item in right click menu

2. missing activation in in-line editor

Replying to bastiK:

  • select something, then change the filter to include these objects

Doesn't work with in-line editor (but "edit" button is respected):

  1. add filter natural=* (auto enabled by JOSM)
  2. focus text in "Text" column, change natural=* to natural=tree (or rock)
  3. hit Enter

Filtered objects are not updated, but they should (it will actually work with Edit button)

3. works for me

Replying to bundesrainer:

But when I mark an area (Click + Hold) the filtered objects are also selected.

Not in r11223.

Select all won't select them too.

Replying to bastiK:

  • use selection history

It will show "Unselectable now" message

Replying to bastiK:

  • undo, such that the properties of a selected change and a filter applies

filters respected well, when you add tags using history: Ctrl+Z Ctrl+Y

Replying to bastiK:

(a) 'search' results in filtered objects being selected

In r11223 I tried to search for natural=tree when they were filtered out, I got "no match for 'natural=tree'" message.

Last edited 11 months ago by openstreetmap.org-user-d1g (previous) (diff)

comment:15 Changed 11 months ago by openstreetmap.org-user-d1g

Priority: majorminor

Changed 11 months ago by openstreetmap.org-user-d1g

Attachment: filters.osm added

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to bundesrainer
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.