Opened 15 years ago
Closed 15 years ago
#4876 closed defect (fixed)
[Patch] Size of tagged nodes no longer configureable
Reported by: | petschge | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core | Version: | |
Keywords: | tagged node size configuration | Cc: | malenki |
Description
Since changeset 3164 the size of tagged nodes can no longer be set via mappaint.node.tagged-size in the configuration. Please reintroduce this.
A way to set color and/or filling for junction nodes would be nice too.
If you want to be really thorough verify that size, color and filling for selected, unselected, tagged and junction nodes can be configured individually.
Attachments (3)
Change History (14)
by , 15 years ago
Attachment: | style.patch added |
---|
comment:1 by , 15 years ago
The properties (a) size, (b) color and (c) filled or not should be orthogonal, somehow: If a tagged node is filled and a connection node is 5 px, then a tagged connection node should be both filled and larger than a default node.
by , 15 years ago
Attachment: | style-v2.patch added |
---|
Fix a bug from the first version of the patch and add support for the MapPaint Style.
comment:2 by , 15 years ago
Node size should probably be the maximum of all the applicable node sizes. If any of the applicable fill properties is the the node should probably be filled. Color is quite difficult though.
comment:3 by , 15 years ago
Would be best if a color could be set as default, i.e. then it equals the normal node color. If both, the junction color and the tagged color are different from default, there must be a precedence.
comment:4 by , 15 years ago
Yeah, precedence of junction color vs tagged color is really the only case we have to solve as selection color should always override the other colors. Personally I don't really care which one takes precedence but would suggest that tagged color overrides junction color (if it differs from the normal node color) as I feel that "junction" is less important then "tagged".
by , 15 years ago
Attachment: | style-v3.patch added |
---|
Add color, filling and size logic as per the discussion in this tiket. Tested and works well for me. Please commit upstream.
comment:5 by , 15 years ago
Summary: | Site of tagged nodes no longer configureable → [Patch] Size of tagged nodes no longer configureable |
---|
comment:6 by , 15 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:7 by , 15 years ago
for the record:
I guess it was this patch that re-set the nodes to the standard color (yellow) in latest, that is, 3184.
comment:8 by , 15 years ago
Cc: | added |
---|
comment:9 by , 15 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
The commiter changed "mappaint.node.fill-junction" to "mappaint.node.fill-onnection" which (in principle) is fine, but is lacking a "c" in the name. Guess this should be fixed ASAP.
Same thing happend to "mappaint.node.onnection-size".
comment:10 by , 15 years ago
comment:11 by , 15 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Thanks for pointing that out.
The following patch should fix the issue but somehow doesn't