Modify

Opened 11 years ago

Closed 9 years ago

#478 closed enhancement (fixed)

Templates support for relation (multipolygon, route, ...) creation and editing

Reported by: anonymous Owned by: framm
Priority: major Milestone:
Component: Plugin Version: latest
Keywords: auto complete, relation editing Cc: Gubaer

Description

Multipolygon creation (like polygon with holes) using relation should be easier.

Now, when I have selected objects for the multipolygon, I have to create a new relation, add selected objects, type in "type" and "multipolygon" in the fields (no autocomplete on these) and press OK. Quite lengthy. I think some button "create multipolygon" with some keyboard shortcut that will do all this would be nice. Perhaps have some other buttons or presets for other relations ...

Attachments (1)

multipoly.zip (4.6 KB) - added by bilbo 10 years ago.
Plugin that solves the bug

Download all attachments as: .zip

Change History (14)

comment:1 Changed 10 years ago by Hasienda

Keywords: auto complete relation editing added
Summary: Easier multipolygon creationAuto complete and templates support for relation (multipolygon, route, ...) creation and editing

The following positive view on the subject is a quote of a duplicate ticket #1684:

"...helpful to have simple support for templates in the relation editor. The benefits are the same as for the templates for ways and nodes.

Usage could be like this: - Create a new relation - Select a template from a menu or combo box, basically we would need one template for every type of relation. E.g. there could by a template for multi-polygon, hiking route etc. - the tags commonly used with this type of relation are added to the relation editor, either completely filled in (e.g. type=route, route=foot) or just the names with empty values for filling in (name, description, operator etc.)."

However I'd like to set a strong emphasis on "auto complete" functionality mentioned by the initial reporter, that makes editing even without templates in JOSM much easier, and don't forget the quit effective prevention of misspellings reached this way.

comment:2 Changed 10 years ago by Ezhick <bestoujev@…>

I was talking about almoste the same thing here:
http://josm.openstreetmap.de/ticket/1725

Changed 10 years ago by bilbo

Attachment: multipoly.zip added

Plugin that solves the bug

comment:3 Changed 10 years ago by bilbo

Component: CorePlugin openstreetbugs

I have attached the plugin (first version, but it should be working fine :) that does automatic multipolygon creation by single click (single menu item). Once the item is clicked, multipolygon is created and inner/outer roles are added automatically to members. Unpack archive to "plugins" subdirectory in svn checkout, then "cd multipoly && ant" to build it.

comment:4 in reply to:  2 Changed 10 years ago by Hasienda

Replying to Ezhick <bestoujev@gmail.com>:

I was talking about almoste the same thing here:
#1725

Well, and I closed that ticket now in favor of this one - only one ticket for each issue to be solved.

comment:5 Changed 10 years ago by Hasienda

Summary: Auto complete and templates support for relation (multipolygon, route, ...) creation and editing[new plugin] Auto complete and templates support for relation (multipolygon, route, ...) creation and editing

Have a look at #1982 for another nice description of a route relation preset. #2001 is asking for the auto complete feature again.

The recently added proposal for a solution by plugin should be announced in the ticket title. Done.

comment:6 Changed 10 years ago by stoecker

The attached file does not solve the auto-complete issue at all. Also It does not solve the preset issue so I reopened the bugs.

Then the action to create multipolygons does not cover the way JOSM handles multipolygons. Advanced multipolygons can consist of multiple outer and inner ways which altogether may be closed or not, as only the combination of all elements needs to be closed.

Also a multipolygon way may be memeber of another multipolygon.

comment:7 Changed 10 years ago by stoecker

P.S. I do not like the idea of another plugin just for that action, so I probably will add the action to utilsplugin when I find time next days. It is not ready to be added to main JOSM.

comment:8 Changed 10 years ago by bilbo

I don't think the plugin is good as some permanent solution (plus it does not solve all the issues), I meant it rather as temporary workaround till there is some more comfortable way for multipolygon creating.

For interested people I built a JAR out of the sources I have posted here and I have put it at http://git.wz.cz/multipoly.jar

If you want to add this to utilsplugin, feel free to do so, you have the source :)

comment:9 Changed 10 years ago by anonymous

It would be great to finish multipolygon plugin idea. Creating of multipoly is too difficult for normal user and too long for advanced users.

comment:10 Changed 10 years ago by stoecker

Summary: [new plugin] Auto complete and templates support for relation (multipolygon, route, ...) creation and editingAuto complete and templates support for relation (multipolygon, route, ...) creation and editing

comment:11 Changed 10 years ago by Gubaer

Summary: Auto complete and templates support for relation (multipolygon, route, ...) creation and editingTemplates support for relation (multipolygon, route, ...) creation and editing

auto complete support is now available (since r1762)

comment:12 Changed 10 years ago by Gubaer

Cc: Gubaer added

comment:13 Changed 9 years ago by stoecker

Resolution: fixed
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain framm.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.