Modify

Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#4742 closed defect (fixed)

validator: do not warn about deleting a "out-of-downloaded-area node" with id:0 when repairing "doubled nodes"

Reported by: skyper Owned by: team
Priority: minor Milestone:
Component: Core Version: latest
Keywords: validator double node repair Cc:

Description

Please use the same function to repair "doubled nodes" that is used for merging nodes.

Right now josm warns about deleting a "outside" node with id:0 when repairing "double nodes". If I merge these nodes manually it does not warn.

Attachments (1)

bug_4742.osm (531.6 KB) - added by skyper 9 years ago.
example

Download all attachments as: .zip

Change History (9)

comment:1 Changed 9 years ago by skyper

Component: Core validatorCore
Keywords: validator added

Validator moved to Core but problem still exists.

r3695

comment:2 Changed 9 years ago by bastiK

cannot reproduce, please attach *.osm

comment:3 Changed 9 years ago by anonymous

Here you go.

I am not sure if you have to warn at all, even if the two nodes have existing ids. But you gonna get problems with the french way of imported survey points. They should be added as relations like the TMC-Points but often are not.

Changed 9 years ago by skyper

Attachment: bug_4742.osm added

example

comment:4 Changed 9 years ago by bastiK

Resolution: fixed
Status: newclosed

In [3700/josm]:

fixed #4742 - validator: do not warn about deleting a "out-of-downloaded-area node" with id:0 when repairing "doubled nodes"

comment:5 in reply to:  3 Changed 9 years ago by bastiK

Replying to anonymous:

Here you go.

I am not sure if you have to warn at all, even if the two nodes have existing ids. But you gonna get problems with the french way of imported survey points. They should be added as relations like the TMC-Points but often are not.

i don't understand the 2nd part. so we better warn if both nodes have id > 0 ?

comment:6 Changed 9 years ago by anonymous

If you can read french, have a look at https://wiki.openstreetmap.org/wiki/WikiProject_France/Rep%C3%A8res_G%C3%A9od%C3%A9siques#Permanence_des_rep.C3.A8res

Anyway I was wrong !
They are importing surway points and if there are points at the same location but different height there are doubled nodes, but the ele-tag should be different.

With different tag values should not be any auto-repair right.

comment:7 in reply to:  6 Changed 9 years ago by anonymous

Replying to anonymous:

anonymous is me (sorry have connections problems)

With different tag values there should not be any auto-repair right.

comment:8 Changed 9 years ago by skyper

it happend again.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.